fix(docker): copy providers/ into rust-builder stage#1211
Merged
Conversation
The openshell-providers crate uses `include_str!("../../../providers/*.yaml")`
to embed provider profile YAML at compile time. The rust-builder stage in
Dockerfile.images only copied `crates/` and `proto/`, so source builds
(BUILD_FROM_SOURCE=1, used by Skaffold dev) failed with:
error: couldn't read `crates/openshell-providers/src/../../../providers/anthropic.yaml`
Copy `providers/` into the build context alongside the other source trees
so `include_str!` resolves.
TaylorMutch
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
drew
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source-built Docker images (
BUILD_FROM_SOURCE=1, the path Skaffold dev uses) currently fail because therust-builderstage indeploy/docker/Dockerfile.imagesdoes not copy the repo'sproviders/directory into the build context. Theopenshell-providerscrate embeds provider profile YAML viainclude_str!("../../../providers/*.yaml"), so the build aborts with:This blocks
mise run helm:skaffold:dev/helm:skaffold:runfor anyone onmain. One-line fix: addCOPY providers/ providers/next to the other source-tree copies.Related Issue
Changes
deploy/docker/Dockerfile.images: copyproviders/into therust-builderstage soinclude_str!for provider profile YAML resolves.Testing
mise run pre-commitpasses (no Rust changes; only the Dockerfile)mise run helm:skaffold:runagainst a local k3d cluster — verifying now on a downstream branch.Checklist