Skip to content

fix(installer): install release formula from Homebrew tap#1222

Merged
drew merged 4 commits intomainfrom
fix/install-dev-homebrew-tap
May 7, 2026
Merged

fix(installer): install release formula from Homebrew tap#1222
drew merged 4 commits intomainfrom
fix/install-dev-homebrew-tap

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 6, 2026

Summary

Fix the macOS install-dev.sh Homebrew path by staging the downloaded release formula in the nvidia/openshell tap before installing it. This avoids current Homebrew rejecting temp openshell.rb paths while preserving the release formula install flow for either the default dev release or a tagged release selected with OPENSHELL_VERSION.

The change also makes the formula postinstall idempotent so reinstalls can refresh the Hypervisor entitlement plist and re-run codesign.

Related Issue

None.

Changes

  • Stage the downloaded release formula into the nvidia/openshell Homebrew tap before install or reinstall.
  • Install and restart services by fully qualified formula name.
  • Patch older downloaded formulas locally from entitlements.write to entitlements.atomic_write before staging.
  • Update the generated Homebrew formula to use atomic_write for the entitlement plist going forward.
  • Document the tap behavior in the VM driver README.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)
  • sh -n install-dev.sh
  • shellcheck install-dev.sh
  • uv run pytest python/openshell/release_formula_test.py
  • git diff --check
  • sh ./install-dev.sh verified Homebrew reinstall from nvidia/openshell/openshell, postinstall codesign, and qualified service restart

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 6, 2026 23:53
drew added 3 commits May 6, 2026 17:16
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew changed the title fix(installer): install dev formula from Homebrew tap fix(installer): install release formula from Homebrew tap May 7, 2026
@drew drew enabled auto-merge (squash) May 7, 2026 01:41
@drew drew merged commit fe41d67 into main May 7, 2026
23 checks passed
@drew drew deleted the fix/install-dev-homebrew-tap branch May 7, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants