fix(providers): read opencode config file during credential discovery#1290
Merged
Merged
Conversation
ericcurtin
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
Contributor
Author
|
recheck |
Contributor
Author
|
@drew @johntmyers PTAL |
drew
previously approved these changes
May 12, 2026
Collaborator
|
/ok to test |
@drew, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Collaborator
|
/ok to test 91e89e9 |
Collaborator
|
@ericcurtin looks like lint checks are failing. If you pull the latest changes from main the lockfile failure should resolve itself. |
ericcurtin
force-pushed
the
fix-opencode-config-discovery/ec
branch
from
91e89e9 to
fb0d050
Compare
Contributor
Author
|
@drew rebased and repushed, hopefully it passes this time |
ericcurtin
force-pushed
the
fix-opencode-config-discovery/ec
branch
from
f33ceef to
494f606
Compare
Supplement env-var discovery with API keys stored in the opencode config file at $XDG_CONFIG_HOME/opencode/opencode.json. Keys under provider.<name>.options.apiKey are surfaced as <NAME>_API_KEY env vars; existing env vars take priority over file-sourced values.
ericcurtin
force-pushed
the
fix-opencode-config-discovery/ec
branch
from
494f606 to
aa6dcca
Compare
Collaborator
|
/ok to test aa6dcca |
drew
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supplement env-var discovery with API keys stored in the opencode
config file at $XDG_CONFIG_HOME/opencode/opencode.json. Keys under
provider.<name>.options.apiKeyare surfaced as<NAME>_API_KEYenvvars; existing env vars take priority over file-sourced values.
Related Issue
N/A (reported via direct session)
Changes
OpencodeProvider::discover_existingnow reads$XDG_CONFIG_HOME/opencode/opencode.json(defaulting to~/.config/opencode/opencode.json) in addition to env varsprovider.<name>.options.apiKeyand surfaces them as<NAME_UPPERCASE>_API_KEYcredentials so they are injected into the sandbox environmentTesting
mise run pre-commitpassescargo test -p openshell-providers— 29 passed)Checklist