feat(k8s): support nodeSelector and tolerations from platform_config#1327
Merged
Merged
Conversation
|
Thank you for your interest in contributing to OpenShell, @Arnonrgo. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
Contributor
Author
|
recheck |
Collaborator
|
/ok to test 2769178 |
Extract node_selector and tolerations from the sandbox template's platform_config and apply them to the pod spec. This allows callers to schedule sandbox pods on specific node pools and tolerate taints without requiring first-class proto fields.
2769178 to
8f4253b
Compare
Collaborator
|
/ok to test 8f4253b |
drew
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_selectorandtolerationsfrom the existingplatform_configpassthroughChanges
node_selectorandtolerationsfromplatform_configStruct insandbox_template_to_k8snodeSelectorandtolerationsfieldsTesting
cargo check -p openshell-driver-kubernetespasses