fix(server): add ConnectSupervisor and RelayStream to SANDBOX_METHODS#1475
Merged
TaylorMutch merged 1 commit intoMay 20, 2026
Merged
Conversation
The supervisor's ConnectSupervisor and RelayStream RPCs were missing from the SANDBOX_METHODS exemption list. When OIDC is enabled without mTLS (disable_tls = true), these RPCs are rejected because the supervisor does not carry an OIDC Bearer token. This causes sandbox connect to fail with "supervisor session not connected". Both RPCs are exclusively called by the sandbox supervisor, matching the existing SANDBOX_METHODS pattern. They already work in mTLS-only mode where all requests pass via the TLS handshake. Fixes NVIDIA#1470 Signed-off-by: Adel Zaalouk <azaalouk@redhat.com>
zanetworker
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
|
All contributors have signed the DCO ✍️ ✅ |
Contributor
|
Can confirm this issue and that this fixes it 👍 |
Contributor
Author
|
recheck |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
Collaborator
|
/ok to test 53f794b |
pimlock
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
ConnectSupervisorandRelayStreamto theSANDBOX_METHODSexemption list so the supervisor relay works when OIDC is enabled without mTLS.When the gateway is configured with OIDC authentication and TLS disabled (
disable_tls = true), the supervisor'sConnectSupervisorandRelayStreamgRPC calls are rejected because they require an OIDC Bearer token that the supervisor does not (by design) carry. This causessandbox connectto fail withsupervisor session not connected.The supervisor authenticates via mTLS in TLS-enabled deployments (line 339 in
multiplex.rsbypasses all OIDC checks). In OIDC-only deployments, the existingSANDBOX_METHODSlist exempts other supervisor RPCs (PushSandboxLogs,GetSandboxProviderEnvironment, etc.) but was missing these two relay RPCs.Related Issue
Fixes #1470
Changes
/openshell.v1.OpenShell/ConnectSupervisortoSANDBOX_METHODSincrates/openshell-server/src/auth/oidc.rs/openshell.v1.OpenShell/RelayStreamtoSANDBOX_METHODSsandbox_rpcs_are_sandbox_methodsTesting
mise run pre-commitpassescargo test -p openshell-server -- sandbox_rpcspasses (1 test, including new assertions)cargo test -p openshell-serverpasses (all 10 tests: 6 unit + 4 integration)cargo clippy -p openshell-server --no-depscleanChecklist