feat(providers): derive discovery from profiles#1503
Draft
johntmyers wants to merge 1 commit into
Draft
Conversation
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds profile-backed credential discovery for providers v2 so explicit
--from-existingflows can discover credentials from provider profile metadata instead of requiring a hard-coded provider plugin. The discovery schema references credential names, keeps env vars sourced fromcredentials[*].env_vars, and keeps v2 provider attachment explicit.Related Issue
Closes #1460
Changes
ProviderProfileDiscoveryto the provider profile proto and YAML DTO.discovery.credentialsto the built-in GitHub, Claude Code, and NVIDIA profiles.--from-existingthrough profile-backed discovery whenproviders_v2_enabledis true, while keeping legacy registry discovery for v1.Testing
mise run pre-commitpassesRUSTC_WRAPPER= mise run pre-commit; it failed on pre-existing ignoredarchitecture/plans/*.mdmarkdown lint errors unrelated to this branch. Rust check completed before I stopped the run after the markdown failure had already made the task fail.CARGO_TARGET_DIR=/tmp/openshell-target-1460 RUSTC_WRAPPER= cargo test -p openshell-providersCARGO_TARGET_DIR=/tmp/openshell-target-1460 RUSTC_WRAPPER= cargo test -p openshell-cli --libCARGO_TARGET_DIR=/tmp/openshell-target-1460 RUSTC_WRAPPER= cargo test -p openshell-cli --test provider_commands_integrationCARGO_TARGET_DIR=/tmp/openshell-target-1460 RUSTC_WRAPPER= cargo test -p openshell-cli --test ensure_providers_integrationCARGO_TARGET_DIR=/tmp/openshell-target-1460 RUSTC_WRAPPER= cargo clippy -p openshell-providers -p openshell-cli --all-targets -- -D warningsCARGO_TARGET_DIR=/tmp/openshell-target-1460 RUSTC_WRAPPER= cargo check -p openshell-server --testsChecklist