Skip to content

fix(sandbox): trust exact declared private endpoints#1560

Open
mjamiv wants to merge 1 commit into
NVIDIA:mainfrom
mjamiv:fix/declared-endpoint-private-ip
Open

fix(sandbox): trust exact declared private endpoints#1560
mjamiv wants to merge 1 commit into
NVIDIA:mainfrom
mjamiv:fix/declared-endpoint-private-ip

Conversation

@mjamiv
Copy link
Copy Markdown
Contributor

@mjamiv mjamiv commented May 25, 2026

Summary

  • allow exact user-declared hostname endpoints to resolve to private RFC1918/internal addresses without duplicating allowed_ips
  • keep loopback/link-local/unspecified and blocked control-plane ports denied
  • preserve policy-advisor two-step SSRF flow for advisor-generated proposals

Fixes #1555.

Testing

  • cargo fmt --all -- --check
  • git diff --check
  • cargo test -p openshell-policy
  • cargo test -p openshell-sandbox --lib

@mjamiv mjamiv requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 25, 2026 21:44
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 25, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: auto-populate allowed_ips for explicitly declared policy endpoints resolving to private addresses

1 participant