fix: restrict Python version to <3.14 due to jsonschema-rs/PyO3 incompatibility - #119
Merged
Merged
Conversation
…patibility jsonschema-rs (v0.29.1) fails to build on Python 3.14 because the bundled PyO3 (v0.23.4) does not support Python 3.14. Adjust the requires-python range from <3.15 to <3.14 and remove the 3.14 classifier to accurately reflect supported versions. Fixes NVIDIA#111 Signed-off-by: Perseus Computing <51974392+tcconnally@users.noreply.github.com>
rng1995
approved these changes
Jun 21, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
APPROVE — sensible, minimal compatibility fix. Capping requires-python at <3.14 and dropping the matching classifier is the right call given the jsonschema-rs/PyO3 limitation, and the classifier list stays consistent with the supported range.
Minor / optional (non-blocking): if this is intended to ship as a release, a patch version bump would help the tightened constraint reach resolvers. Re-widen once the native dependency supports 3.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #111: Python 3.14 incompatibility due to outdated PyO3 in jsonschema-rs.
Problem
When installing or running tests on Python 3.14, jsonschema-rs (v0.29.1) fails to compile because the bundled PyO3 (v0.23.4) does not support Python 3.14. SkillSpector's pyproject.toml declares requires-python = ">=3.12,<3.15" which includes Python 3.14.
Fix
Testing
All 621 unit tests pass (same as main).