fix: bound MCP extra to supported major version - #339
Open
koriyoshi2041 wants to merge 1 commit into
Open
Conversation
Signed-off-by: kigland <shuaizhicheng336@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fresh
skillspector[mcp]installs resolve MCP 2.x, which removedmcp.server.fastmcp. The install succeeds, but the server fails at initialization and incorrectly reports that the optional dependency is missing. Fixes #333.Fix
mcppackage from an installed package missing the expected FastMCP moduleTest
uv run pytest -q tests/unit/test_mcp_server.py(10 passed, including stdio initialize/list-tools)uv run ruff check src/skillspector/mcp_server.py tests/unit/test_mcp_server.pyuv run ruff format --check src/skillspector/mcp_server.py tests/unit/test_mcp_server.pygit diff --checkRisk
Low. This deliberately holds the optional server integration on MCP 1.x until SkillSpector migrates to the 2.x API; users that force an incompatible install now receive an accurate error instead of a missing-extra message.