Skip to content

[https://nvbugs/5973214][fix] unwaive qwen3 ci test#12237

Merged
byshiue merged 4 commits intoNVIDIA:mainfrom
byshiue:fix/nvbug_5973214
Apr 14, 2026
Merged

[https://nvbugs/5973214][fix] unwaive qwen3 ci test#12237
byshiue merged 4 commits intoNVIDIA:mainfrom
byshiue:fix/nvbug_5973214

Conversation

@byshiue
Copy link
Copy Markdown
Collaborator

@byshiue byshiue commented Mar 16, 2026

Summary by CodeRabbit

  • Tests
    • Removed a previously skipped test entry, enabling it to run in test execution.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Mar 16, 2026

/bot run --multi-gpu-test --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 16, 2026

📝 Walkthrough

Walkthrough

This PR removes a single SKIP entry from the waived tests list, specifically for the test_nvfp4[latency_moe_trtllm_attention_dp] test in the TestQwen3_235B_A22B test class, enabling that test to run in the integration test suite.

Changes

Cohort / File(s) Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Removed one SKIP entry for accuracy/test_llm_api_pytorch.py::TestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm_attention_dp], re-enabling the test from the waived list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • EmmaQiaoCh
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description contains only the template with no actual content provided in the required sections. Fill in the Description section explaining why the test is being unwaived, and complete the Test Coverage section listing the re-enabled test that validates this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing a waived test for Qwen3 in CI, following the required format with ticket ID and fix type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39037 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: --multi-gpu-test

Link to invocation

@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Mar 16, 2026

/bot help

@github-actions
Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Mar 16, 2026

/bot run --only-multi-gpu-test --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39045 [ run ] triggered by Bot. Commit: d5b213c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39045 [ run ] completed with state SUCCESS. Commit: d5b213c
/LLM/main/L0_MergeRequest_PR pipeline #30317 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@byshiue byshiue requested a review from a team as a code owner March 17, 2026 06:24
@byshiue byshiue requested a review from mikeiovine March 17, 2026 06:24
@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Mar 17, 2026

/bot run --only-multi-gpu-test --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3"

byshiue added 2 commits March 17, 2026 00:19
Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
@byshiue byshiue force-pushed the fix/nvbug_5973214 branch from e848c3b to dc36e42 Compare March 17, 2026 07:19
@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Mar 17, 2026

/bot run --only-multi-gpu-test --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39214 [ run ] triggered by Bot. Commit: dc36e42 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39214 [ run ] completed with state SUCCESS. Commit: dc36e42
/LLM/main/L0_MergeRequest_PR pipeline #30466 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Mar 18, 2026

/bot run --only-multi-gpu-test --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39335 [ run ] triggered by Bot. Commit: ff64fb1 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39335 [ run ] completed with state SUCCESS. Commit: ff64fb1
/LLM/main/L0_MergeRequest_PR pipeline #30582 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Apr 13, 2026

/bot run --only-multi-gpu-test --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42960 [ run ] triggered by Bot. Commit: ff64fb1 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42960 [ run ] completed with state SUCCESS. Commit: ff64fb1
/LLM/main/L0_MergeRequest_PR pipeline #33617 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
@byshiue
Copy link
Copy Markdown
Collaborator Author

byshiue commented Apr 14, 2026

/bot skip --comment "The issue is fixed and the CI has passed"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43123 [ skip ] triggered by Bot. Commit: 9412543 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43123 [ skip ] completed with state SUCCESS. Commit: 9412543
Skipping testing for commit 9412543

Link to invocation

@byshiue byshiue merged commit 69b19c7 into NVIDIA:main Apr 14, 2026
6 of 7 checks passed
chienchunhung pushed a commit to chienchunhung/TensorRT-LLM that referenced this pull request Apr 16, 2026
Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants