[None][fix] Test time conflict in WAN T2V example#13193
Conversation
* Why? PRs NVIDIA#12548 and NVIDIA#12992 have a test-time conflict that was not caught for either since they ran CI independently of one another at the same time. * What? This commit removes the stale part of the configs. Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThe pull request removes the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #44222 [ run ] triggered by Bot. Commit: |
|
PR_Github #44222 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44272 [ run ] triggered by Bot. Commit: |
|
PR_Github #44272 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44297 [ run ] triggered by Bot. Commit: |
|
PR_Github #44297 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44310 [ run ] triggered by Bot. Commit: |
|
PR_Github #44310 [ run ] completed with state
|
|
/bot run |
|
PR_Github #44360 [ run ] triggered by Bot. Commit: |
|
PR_Github #44360 [ run ] completed with state
|
|
/bot run |
|
PR_Github #44471 [ run ] triggered by Bot. Commit: |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
The fix passed in build ID 34645 |
|
PR_Github #44471 [ run ] completed with state |
The quick fix should have been done with NVIDIA#13193. The config update and "skip warmup in testing" will be tracked by the JIRAs. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
PRs #12548 and #12992 have a test-time conflict that was not caught for either since they ran CI independently of one another at the same time.
This commit removes the stale part of the configs.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.