Skip to content

[None][fix] Test time conflict in WAN T2V example#13193

Merged
2ez4bz merged 1 commit intoNVIDIA:mainfrom
2ez4bz:dev-fix-wan-tests
Apr 20, 2026
Merged

[None][fix] Test time conflict in WAN T2V example#13193
2ez4bz merged 1 commit intoNVIDIA:mainfrom
2ez4bz:dev-fix-wan-tests

Conversation

@2ez4bz
Copy link
Copy Markdown
Collaborator

@2ez4bz 2ez4bz commented Apr 19, 2026

  • Why?

PRs #12548 and #12992 have a test-time conflict that was not caught for either since they ran CI independently of one another at the same time.

  • What?

This commit removes the stale part of the configs.

Summary by CodeRabbit

  • Chores
    • Removed disabled teacache configuration blocks from example configuration files to streamline setup.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

* Why?

PRs NVIDIA#12548 and NVIDIA#12992 have a test-time conflict that was not caught for
either since they ran CI independently of one another at the same time.

* What?

This commit removes the stale part of the configs.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@2ez4bz 2ez4bz requested a review from a team as a code owner April 19, 2026 20:42
@2ez4bz 2ez4bz requested review from kaiyux and venkywonka April 19, 2026 20:42
@2ez4bz
Copy link
Copy Markdown
Collaborator Author

2ez4bz commented Apr 19, 2026

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

📝 Walkthrough

Walkthrough

The pull request removes the teacache configuration block from three visual generation configuration files, specifically deleting the enable_teacache: false setting. All other configuration options remain unchanged.

Changes

Cohort / File(s) Summary
Configuration Updates
examples/visual_gen/configs/wan2.2-t2v-fp4-1gpu.yaml, examples/visual_gen/configs/wan2.2-t2v-fp4-4gpu.yaml, examples/visual_gen/configs/wan2.2-t2v-fp8-8gpu.yaml
Removed teacache configuration block containing enable_teacache: false from all three configuration files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks required sections: Title with proper format/ID is missing, 'Description' section is empty, 'Test Coverage' section is empty, and most PR Checklist items are not confirmed. Add a properly formatted title (e.g., [TRTLLM-13193][fix] or [#13193][fix]), fill in the Description section explaining the conflict details, document test coverage, and confirm relevant checklist items were reviewed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a test-time conflict in WAN T2V example configs by deleting the stale teacache configuration block.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44222 [ run ] triggered by Bot. Commit: fb64f0c Link to invocation

Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44222 [ run ] completed with state FAILURE. Commit: fb64f0c
/LLM/main/L0_MergeRequest_PR pipeline #34645 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@2ez4bz
Copy link
Copy Markdown
Collaborator Author

2ez4bz commented Apr 20, 2026

/bot run --disable-fail-fast

@2ez4bz 2ez4bz enabled auto-merge (squash) April 20, 2026 03:03
@2ez4bz 2ez4bz disabled auto-merge April 20, 2026 03:03
@2ez4bz 2ez4bz enabled auto-merge (squash) April 20, 2026 03:03
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44272 [ run ] triggered by Bot. Commit: fb64f0c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44272 [ run ] completed with state FAILURE. Commit: fb64f0c
/LLM/main/L0_MergeRequest_PR pipeline #34693 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@2ez4bz
Copy link
Copy Markdown
Collaborator Author

2ez4bz commented Apr 20, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44297 [ run ] triggered by Bot. Commit: fb64f0c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44297 [ run ] completed with state FAILURE. Commit: fb64f0c
/LLM/main/L0_MergeRequest_PR pipeline #34718 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@2ez4bz
Copy link
Copy Markdown
Collaborator Author

2ez4bz commented Apr 20, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44310 [ run ] triggered by Bot. Commit: fb64f0c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44310 [ run ] completed with state FAILURE. Commit: fb64f0c
/LLM/main/L0_MergeRequest_PR pipeline #34731 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@2ez4bz
Copy link
Copy Markdown
Collaborator Author

2ez4bz commented Apr 20, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44360 [ run ] triggered by Bot. Commit: fb64f0c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44360 [ run ] completed with state FAILURE. Commit: fb64f0c
/LLM/main/L0_MergeRequest_PR pipeline #34775 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@Funatiq
Copy link
Copy Markdown
Collaborator

Funatiq commented Apr 20, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44471 [ run ] triggered by Bot. Commit: fb64f0c Link to invocation

@2ez4bz
Copy link
Copy Markdown
Collaborator Author

2ez4bz commented Apr 20, 2026

/bot help

@github-actions
Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@2ez4bz
Copy link
Copy Markdown
Collaborator Author

2ez4bz commented Apr 20, 2026

The fix passed in build ID 34645

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44471 [ run ] completed with state SUCCESS. Commit: fb64f0c
/LLM/main/L0_MergeRequest_PR pipeline #34875 completed with status: 'SUCCESS'

CI Report

Link to invocation

@2ez4bz 2ez4bz merged commit c4c7685 into NVIDIA:main Apr 20, 2026
9 of 12 checks passed
zhenhuaw-me added a commit to zhenhuaw-me/TensorRT-LLM that referenced this pull request Apr 22, 2026
The quick fix should have been done with NVIDIA#13193.

The config update and "skip warmup in testing" will be tracked by the JIRAs.

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants