Skip to content

[https://nvbugs/6097980][fix] unwaive Wan T2V example#13316

Open
zhenhuaw-me wants to merge 1 commit intoNVIDIA:mainfrom
zhenhuaw-me:unwaive-wan-test
Open

[https://nvbugs/6097980][fix] unwaive Wan T2V example#13316
zhenhuaw-me wants to merge 1 commit intoNVIDIA:mainfrom
zhenhuaw-me:unwaive-wan-test

Conversation

@zhenhuaw-me
Copy link
Copy Markdown
Member

@zhenhuaw-me zhenhuaw-me commented Apr 22, 2026

The quick fix should have been done with #13193.

The config update and "skip warmup in testing" will be tracked by the JIRAs.

Summary by CodeRabbit

  • Tests
    • A previously skipped test case has been re-enabled, expanding test coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

The quick fix should have been done with NVIDIA#13193.

The config update and "skip warmup in testing" will be tracked by the JIRAs.

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
@zhenhuaw-me
Copy link
Copy Markdown
Member Author

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fe506aa1-b747-44ba-b607-c2b0904a275a

📥 Commits

Reviewing files that changed from the base of the PR and between 0d2bea7 and a16f57a.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single test waiver entry for full:DGX_B200/examples/test_visual_gen.py::test_wan_t2v_example was removed from the waiver list, indicating that this test is no longer expected to be skipped.

Changes

Cohort / File(s) Summary
Test Waivers
tests/integration/test_lists/waives.txt
Removed one SKIP waiver entry for test_wan_t2v_example, referencing issue https://nvbugs/6097980.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. It mentions this is a quick fix and references related work, but does not fill the template's Description, Test Coverage, and other required sections properly. Complete the Description section explaining the issue and solution, add Test Coverage details, and ensure the PR Checklist is properly reviewed before merging.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly matches the changeset: it references the NVBugs ID and describes removing (unwaiving) the skip for the Wan T2V example test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44873 [ run ] triggered by Bot. Commit: a16f57a Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants