[https://nvbugs/6075345][fix] test_llmapi_launch_multiple_tasks ignored the task_script parameter and always#13273
Conversation
…nch_multiple_tasks The test was ignoring the task_script parameter and always running _run_multi_llm_tasks.py, which fails with ModuleNotFoundError because utils.llm_data is not importable from the mpirun subprocess context. Use the parametrized task_script (_run_mpi_comm_task.py and _run_multi_mpi_comm_tasks.py) which are the intended test scripts. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA test method is modified to use a parametrized argument for selecting test scripts instead of hard-coding a single script name, enabling the same test to run with different script files under different parameterized test cases. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
|
/bot run |
|
PR_Github #44926 [ run ] triggered by Bot. Commit: |
|
PR_Github #44926 [ run ] completed with state
|
|
Close and continue the work on #13588 |
Pull request was closed
Summary
task_scriptparameter and always ran_run_multi_llm_tasks.py, which fails withModuleNotFoundError: No module named 'utils.llm_data'because the mpirun subprocess lacks the pytest sys.path setup needed for that import._run_multi_llm_tasks.pywith the parametrizedtask_scriptvariable so the test runs the intended MPI comm task scripts.Test plan
Links
Summary by CodeRabbit