Skip to content

[https://nvbugs/6075345][fix] test_llmapi_launch_multiple_tasks ignored the task_script parameter and always#13273

Closed
tensorrt-cicd wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6075345
Closed

[https://nvbugs/6075345][fix] test_llmapi_launch_multiple_tasks ignored the task_script parameter and always#13273
tensorrt-cicd wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6075345

Conversation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

@tensorrt-cicd tensorrt-cicd commented Apr 21, 2026

Summary

  • Fix for NVBugs 6075345: [TensorRT-LLM][L0][Pre-Merge][main] Test failed: unittest/llmapi/test_mpi_session.py
  • Root cause: test_llmapi_launch_multiple_tasks ignored the task_script parameter and always ran _run_multi_llm_tasks.py, which fails with ModuleNotFoundError: No module named 'utils.llm_data' because the mpirun subprocess lacks the pytest sys.path setup needed for that import.
  • Fix: Replace the hardcoded _run_multi_llm_tasks.py with the parametrized task_script variable so the test runs the intended MPI comm task scripts.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

  • Tests
    • Enhanced test parametrization to support multiple test scenarios with different configurations, improving test flexibility and coverage.

…nch_multiple_tasks

The test was ignoring the task_script parameter and always running
_run_multi_llm_tasks.py, which fails with ModuleNotFoundError because
utils.llm_data is not importable from the mpirun subprocess context.
Use the parametrized task_script (_run_mpi_comm_task.py and
_run_multi_mpi_comm_tasks.py) which are the intended test scripts.

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9414d1a0-fe43-4e03-9376-15b036903c11

📥 Commits

Reviewing files that changed from the base of the PR and between ab315dd and ada760c.

📒 Files selected for processing (1)
  • tests/unittest/llmapi/test_mpi_session.py

📝 Walkthrough

Walkthrough

A test method is modified to use a parametrized argument for selecting test scripts instead of hard-coding a single script name, enabling the same test to run with different script files under different parameterized test cases.

Changes

Cohort / File(s) Summary
Test Parametrization
tests/unittest/llmapi/test_mpi_session.py
Modified test_llmapi_launch_multiple_tasks to construct test_file path using the parametrized task_script argument instead of a hard-coded script name, allowing the test to execute different scripts based on parametrization values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the specific bug being fixed and the root cause (test ignoring the parametrized task_script parameter), directly matching the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn
Copy link
Copy Markdown
Collaborator

/bot run

@Superjomn Superjomn enabled auto-merge (squash) April 22, 2026 07:09
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator Author

PR_Github #44926 [ run ] triggered by Bot. Commit: ada760c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator Author

PR_Github #44926 [ run ] completed with state SUCCESS. Commit: ada760c
/LLM/main/L0_MergeRequest_PR pipeline #35255 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@Superjomn
Copy link
Copy Markdown
Collaborator

Close and continue the work on #13588

@Superjomn Superjomn closed this Apr 29, 2026
auto-merge was automatically disabled April 29, 2026 02:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants