Skip to content

[https://nvbugs/6075345][fix] test_llmapi_launch_multiple_tasks ignored the task_script parameter and always#13588

Merged
Superjomn merged 2 commits into
NVIDIA:mainfrom
Superjomn:repair-bot-bug6075345
May 7, 2026
Merged

[https://nvbugs/6075345][fix] test_llmapi_launch_multiple_tasks ignored the task_script parameter and always#13588
Superjomn merged 2 commits into
NVIDIA:mainfrom
Superjomn:repair-bot-bug6075345

Conversation

@Superjomn
Copy link
Copy Markdown
Collaborator

@Superjomn Superjomn commented Apr 29, 2026

Summary by CodeRabbit

Release Notes

  • Tests
    • Fixed a test that was previously skipped, enabling it to run with multiple task script parameters.
    • Removed a test waiver to allow continuous testing of the multiple task launcher functionality.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

📝 Walkthrough

Walkthrough

The test waiver for test_llmapi_launch_multiple_tasks is removed from the integration test skip list, and the test implementation is modified to use a parametrized task_script value instead of a hardcoded script filename reference.

Changes

Cohort / File(s) Summary
Test Waiver Removal
tests/integration/test_lists/waives.txt
Removed the skip waiver for unittest/llmapi/test_mpi_session.py::test_llmapi_launch_multiple_tasks.
Test Parametrization
tests/unittest/llmapi/test_mpi_session.py
Updated test_llmapi_launch_multiple_tasks to use parametrized task_script value instead of a hardcoded script filename, enabling execution of different launcher scripts based on test parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty. All required sections including Description and Test Coverage are blank, with only checklist items visible. Fill in the Description section explaining the issue and solution, and the Test Coverage section listing relevant tests that safeguard the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title correctly identifies the main change: fixing test_llmapi_launch_multiple_tasks to use the task_script parameter instead of ignoring it.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@Superjomn
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46034 [ run ] triggered by Bot. Commit: c877659 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46034 [ run ] completed with state FAILURE. Commit: c877659
/LLM/main/L0_MergeRequest_PR pipeline #36180 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@Superjomn
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46070 [ run ] triggered by Bot. Commit: c877659 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46070 [ run ] completed with state FAILURE. Commit: c877659
/LLM/main/L0_MergeRequest_PR pipeline #36216 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@Superjomn
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2"

tensorrt-cicd and others added 2 commits May 6, 2026 08:42
…nch_multiple_tasks

The test was ignoring the task_script parameter and always running
_run_multi_llm_tasks.py, which fails with ModuleNotFoundError because
utils.llm_data is not importable from the mpirun subprocess context.
Use the parametrized task_script (_run_mpi_comm_task.py and
_run_multi_mpi_comm_tasks.py) which are the intended test scripts.

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Superjomn <328693+Superjomn@users.noreply.github.com>
@Superjomn Superjomn force-pushed the repair-bot-bug6075345 branch from c877659 to 1514726 Compare May 6, 2026 08:46
@Superjomn
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46961 [ run ] triggered by Bot. Commit: 1514726 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46961 [ run ] completed with state FAILURE. Commit: 1514726

Link to invocation

@Superjomn
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46995 [ run ] triggered by Bot. Commit: 1514726 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46995 [ run ] completed with state SUCCESS. Commit: 1514726
/LLM/main/L0_MergeRequest_PR pipeline #36971 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@Superjomn
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Test / DGX_H100-2_GPUs-PyTorch-Others-1 / test_unittests_v2[unittest/llmapi/test_mpi_session.py::test_llmapi_launch_multiple_tasks] – DGX_H100-2_GPUs-PyTorch-Others-1.test_unittests passed"

@Superjomn Superjomn enabled auto-merge (squash) May 7, 2026 03:11
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47092 [ skip ] triggered by Bot. Commit: 1514726 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47092 [ skip ] completed with state SUCCESS. Commit: 1514726
Skipping testing for commit 1514726

Link to invocation

@shuyixiong shuyixiong self-requested a review May 7, 2026 07:50
Copy link
Copy Markdown
Collaborator

@shuyixiong shuyixiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Superjomn Superjomn merged commit 5d2d455 into NVIDIA:main May 7, 2026
7 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
…ed the task_script parameter and always (NVIDIA#13588)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Superjomn <328693+Superjomn@users.noreply.github.com>
Co-authored-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants