[https://nvbugs/6075345][fix] test_llmapi_launch_multiple_tasks ignored the task_script parameter and always#13588
Conversation
📝 WalkthroughWalkthroughThe test waiver for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2" |
|
PR_Github #46034 [ run ] triggered by Bot. Commit: |
|
PR_Github #46034 [ run ] completed with state
|
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2" |
|
PR_Github #46070 [ run ] triggered by Bot. Commit: |
|
PR_Github #46070 [ run ] completed with state
|
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2" |
…nch_multiple_tasks The test was ignoring the task_script parameter and always running _run_multi_llm_tasks.py, which fails with ModuleNotFoundError because utils.llm_data is not importable from the mpirun subprocess context. Use the parametrized task_script (_run_mpi_comm_task.py and _run_multi_mpi_comm_tasks.py) which are the intended test scripts. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Superjomn <328693+Superjomn@users.noreply.github.com>
c877659 to
1514726
Compare
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2" |
|
PR_Github #46961 [ run ] triggered by Bot. Commit: |
|
PR_Github #46961 [ run ] completed with state |
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-2_GPUs-PyTorch-Others-2" --disable-fail-fast |
|
PR_Github #46995 [ run ] triggered by Bot. Commit: |
|
PR_Github #46995 [ run ] completed with state |
|
/bot skip --comment "Test / DGX_H100-2_GPUs-PyTorch-Others-1 / test_unittests_v2[unittest/llmapi/test_mpi_session.py::test_llmapi_launch_multiple_tasks] – DGX_H100-2_GPUs-PyTorch-Others-1.test_unittests passed" |
|
PR_Github #47092 [ skip ] triggered by Bot. Commit: |
|
PR_Github #47092 [ skip ] completed with state |
…ed the task_script parameter and always (NVIDIA#13588) Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com> Signed-off-by: Superjomn <328693+Superjomn@users.noreply.github.com> Co-authored-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Summary by CodeRabbit
Release Notes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.