[None][test] Waive 5 failed cases for main in QA CI#14789
Conversation
Bug(s): 6059036, 6181383, 6211193, 6215689, 6240420 Requested by: qa@nvidia.com Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_CLUSTER_TEST/1484/ Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --skip-test |
📝 WalkthroughWalkthroughFive new test case skip entries are added to ChangesTest skip entries update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
16-17: Coverage follow-up needed outside this PR (waiver-only change).Coverage status:
accuracy/test_llm_api_autodeploy.py→ needs follow-up outside PRaccuracy/test_llm_api_pytorch.py→ needs follow-up outside PRaccuracy/test_llm_api_pytorch_multimodal.py→ needs follow-up outside PRtest_e2e.py→ needs follow-up outside PRActionable ask: please track unwaive criteria per bug in
tests/integration/test_lists/waives.txt(owner + target milestone) and open/confirm companion QA tasks to re-enable these tests once fixes land.Based on learnings: in
tests/integration/test_lists/waives.txt, prefer short nvbug URL formathttps://nvbugs/XXXX; the new entries are consistent.Also applies to: 117-117, 133-133, 300-300
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 16 - 17, Update tests/integration/test_lists/waives.txt entries for the skipped tests (e.g., accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry and similar entries for accuracy/test_llm_api_pytorch.py, accuracy/test_llm_api_pytorch_multimodal.py, test_e2e.py) to include the unwaive criteria: add an owner and a target milestone per nvbug (use the short nvbugs URL format https://nvbugs/XXXX), and then open/confirm companion QA tasks that track re-enabling each test once the bug is fixed, recording the QA issue IDs alongside the waiver entries so follow-up is traceable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 16-17: Update tests/integration/test_lists/waives.txt entries for
the skipped tests (e.g.,
accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry
and similar entries for accuracy/test_llm_api_pytorch.py,
accuracy/test_llm_api_pytorch_multimodal.py, test_e2e.py) to include the unwaive
criteria: add an owner and a target milestone per nvbug (use the short nvbugs
URL format https://nvbugs/XXXX), and then open/confirm companion QA tasks that
track re-enabling each test once the bug is fixed, recording the QA issue IDs
alongside the waiver entries so follow-up is traceable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7becba0e-9af0-4974-b091-e9aefa10920b
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --skip-test |
|
PR_Github #51329 [ run ] triggered by Bot. Commit: |
|
PR_Github #51329 [ run ] completed with state |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
1 similar comment
|
/bot reuse-pipeline |
|
PR_Github #51464 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #51464 [ reuse-pipeline ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainJenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_CLUSTER_TEST/1484/
Bug(s): 6059036, 6181383, 6211193, 6215689, 6240420
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit