[None][infra] Waive 5 failed cases for main in post-merge 2755#14883
Conversation
Bug(s): 6260890, 6260897, 6260907, 6260915 Requested by: @EmmaQiaoCh Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThis PR updates the test waiver list ( ChangesTest waiver updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
8-8: QA coverage status: waives list update is sufficient for this PR; test-behavior follow-up needed outside this PR.
tests/integration/test_lists/waives.txt: sufficient (all added entries are valid, specific nodeids with parseableSKIP (reason)format).tests/integration/accuracy/test_disaggregated_serving.py: needs follow-up outside PR (root-cause fix forTestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True]).tests/integration/accuracy/test_llm_api_pytorch.py: needs follow-up outside PR (root-cause fix forTestKimiK25::test_nvfp4[dep8]andTestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus[...]).tests/integration/unittest/bindings/test_transfer_agent_bindings.py: needs follow-up outside PR (root-cause fix forTestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout).As per coding guidelines, for
tests/**I’m classifying coverage/actionability explicitly per impacted test files. Based on learnings, the short nvbug URL format is correctly used in all new entries.Also applies to: 90-90, 145-145, 147-147, 368-368
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 8, The waives entry added to tests/integration/test_lists/waives.txt is fine but the failing tests need tracked follow-ups outside this PR: ensure the waived line uses the parseable "SKIP (reason)" format in tests/integration/test_lists/waives.txt and confirm all new entries match that pattern; then create or update follow-up issues (or TODO markers) referencing the specific tests TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True], TestKimiK25::test_nvfp4[dep8], TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus..., and TestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout so root-cause fixes are tracked outside this PR.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 8: The waives entry added to tests/integration/test_lists/waives.txt is
fine but the failing tests need tracked follow-ups outside this PR: ensure the
waived line uses the parseable "SKIP (reason)" format in
tests/integration/test_lists/waives.txt and confirm all new entries match that
pattern; then create or update follow-up issues (or TODO markers) referencing
the specific tests
TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True],
TestKimiK25::test_nvfp4[dep8],
TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus..., and
TestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout so
root-cause fixes are tracked outside this PR.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 91a84b50-d61d-4a69-bde8-b518d0d44c93
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #51728 [ run ] triggered by Bot. Commit: |
|
/bot skip --comment "Previous CI passed check test list" |
|
PR_Github #51736 [ skip ] triggered by Bot. Commit: |
|
PR_Github #51728 [ run ] completed with state |
|
PR_Github #51736 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @EmmaQiaoCh)
Target branch:
mainBug(s): 6260890, 6260897, 6260907, 6260915
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit
Release Notes