Skip to content

[None][infra] Waive 5 failed cases for main in post-merge 2755#14883

Merged
EmmaQiaoCh merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260603-020138
Jun 3, 2026
Merged

[None][infra] Waive 5 failed cases for main in post-merge 2755#14883
EmmaQiaoCh merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260603-020138

Conversation

@ZhanruiSunCh
Copy link
Copy Markdown
Collaborator

@ZhanruiSunCh ZhanruiSunCh commented Jun 3, 2026

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @EmmaQiaoCh)
Target branch: main
Bug(s): 6260890, 6260897, 6260907, 6260915

Waive entries added

accuracy/test_disaggregated_serving.py::TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True] SKIP (https://nvbugs/6260907)
accuracy/test_llm_api_pytorch.py::TestKimiK25::test_nvfp4[dep8] SKIP (https://nvbugs/6260890)
accuracy/test_llm_api_pytorch.py::TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus[target_sparsity_0.5-fp8kv=False] SKIP (https://nvbugs/6260915)
accuracy/test_llm_api_pytorch.py::TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus[target_sparsity_0.9-fp8kv=False] SKIP (https://nvbugs/6260915)
unittest/bindings/test_transfer_agent_bindings.py::TestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout SKIP (https://nvbugs/6260897)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

Release Notes

  • Tests
    • Added test case waivers for additional parameterizations
    • Expanded existing test waiver configurations with additional combinations

Bug(s): 6260890, 6260897, 6260907, 6260915
Requested by: @EmmaQiaoCh

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator

/bot run

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) June 3, 2026 02:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the test waiver list (tests/integration/test_lists/waives.txt) by adding SKIP markers for four test case parameterizations: TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True], TestKimiK25::test_nvfp4[dep8], and TestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout, plus expanding the existing TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus waiver set with additional parameter combinations.

Changes

Test waiver updates

Layer / File(s) Summary
Test case skip waivers
tests/integration/test_lists/waives.txt
Added SKIP waivers for three new test parameterizations and expanded the existing TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus waiver block to include additional target_sparsity/fp8kv parameter combinations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14789: Both PRs modify the same tests/integration/test_lists/waives.txt by adding SKIP/waiver entries for specific failing parameterized tests, including new Test…::test_nvfp4-style skips.
  • NVIDIA/TensorRT-LLM#14802: Both PRs modify tests/integration/test_lists/waives.txt to add/extend waivers for the same failing tests, especially TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus and nearby Qwen3/KimiK25 waiver entries.
  • NVIDIA/TensorRT-LLM#14854: Both PRs modify tests/integration/test_lists/waives.txt by extending the same SKIP/waiver set for failing integration test parameterizations, including similar model/test-case families.

Suggested reviewers

  • chzblych
  • EmmaQiaoCh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the required template format and accurately summarizes the PR's main change: waiving failed test cases.
Description check ✅ Passed The description clearly explains what was changed (5 waived test cases) and why (references to NVBug IDs), though some optional checklist items are not addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

8-8: QA coverage status: waives list update is sufficient for this PR; test-behavior follow-up needed outside this PR.

  • tests/integration/test_lists/waives.txt: sufficient (all added entries are valid, specific nodeids with parseable SKIP (reason) format).
  • tests/integration/accuracy/test_disaggregated_serving.py: needs follow-up outside PR (root-cause fix for TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True]).
  • tests/integration/accuracy/test_llm_api_pytorch.py: needs follow-up outside PR (root-cause fix for TestKimiK25::test_nvfp4[dep8] and TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus[...]).
  • tests/integration/unittest/bindings/test_transfer_agent_bindings.py: needs follow-up outside PR (root-cause fix for TestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout).

As per coding guidelines, for tests/** I’m classifying coverage/actionability explicitly per impacted test files. Based on learnings, the short nvbug URL format is correctly used in all new entries.

Also applies to: 90-90, 145-145, 147-147, 368-368

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 8, The waives entry added to
tests/integration/test_lists/waives.txt is fine but the failing tests need
tracked follow-ups outside this PR: ensure the waived line uses the parseable
"SKIP (reason)" format in tests/integration/test_lists/waives.txt and confirm
all new entries match that pattern; then create or update follow-up issues (or
TODO markers) referencing the specific tests
TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True],
TestKimiK25::test_nvfp4[dep8],
TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus..., and
TestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout so
root-cause fixes are tracked outside this PR.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 8: The waives entry added to tests/integration/test_lists/waives.txt is
fine but the failing tests need tracked follow-ups outside this PR: ensure the
waived line uses the parseable "SKIP (reason)" format in
tests/integration/test_lists/waives.txt and confirm all new entries match that
pattern; then create or update follow-up issues (or TODO markers) referencing
the specific tests
TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True],
TestKimiK25::test_nvfp4[dep8],
TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus..., and
TestNixlFunctionalTransfer::test_nixl_wait_in_progress_on_zero_timeout so
root-cause fixes are tracked outside this PR.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 91a84b50-d61d-4a69-bde8-b518d0d44c93

📥 Commits

Reviewing files that changed from the base of the PR and between e1ed5e0 and dc9b6fa.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51728 [ run ] triggered by Bot. Commit: dc9b6fa Link to invocation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator

/bot skip --comment "Previous CI passed check test list"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51736 [ skip ] triggered by Bot. Commit: dc9b6fa Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51728 [ run ] completed with state ABORTED. Commit: dc9b6fa

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51736 [ skip ] completed with state SUCCESS. Commit: dc9b6fa
Skipping testing for commit dc9b6fa

Link to invocation

@EmmaQiaoCh EmmaQiaoCh merged commit 66577ac into NVIDIA:main Jun 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants