[None][fix] Add KV cache V2 recompute pause path - #14816
Conversation
|
/bot run |
|
PR_Github #51334 [ run ] triggered by Bot. Commit: |
|
@lowsfer could you review this? thanks |
e9ba97c to
9d6ef45
Compare
|
PR_Github #51334 [ run ] completed with state
|
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
9d6ef45 to
1e8ba4a
Compare
|
/bot run |
|
PR_Github #51337 [ run ] triggered by Bot. Commit: |
|
PR_Github #51337 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #51492 [ run ] triggered by Bot. Commit: |
|
PR_Github #51492 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #51796 [ run ] triggered by Bot. Commit: |
|
PR_Github #51796 [ run ] completed with state
|
|
closing in favor of #15252 |
@coderabbitai summary
Description
This PR separates destructive recompute pause from ordinary KV cache V2 suspension in the Python scheduler/executor path. It adds a scheduler output field for recompute-paused requests with a default empty value so V1 scheduler construction remains unchanged, gates suspended-victim promotion on host-tier availability, and has PyExecutor terminate/replay recompute-paused requests separately from ordinary suspended requests.
Test Coverage
python3 -m pytest -s tests/unittest/_torch/executor/test_kv_cache_v2_scheduler.py tests/unittest/_torch/executor/test_scheduler_serializable_output.pypython3 -m pytest -s tests/unittest/pyexecutor/test_iter_stats_populate.py tests/unittest/_torch/executor/test_py_scheduler.py -k "paused or full_pipeline_output_structure"python3 -m pytest -s tests/unittest/_torch/executor/test_py_scheduler.py -k full_pipeline_output_structuregit diff --checkPR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.