[TRTLLM-13446][test] Add FLUX infer() num_images_per_prompt forwardin…#15745
Conversation
📝 WalkthroughWalkthroughA new unit test file ChangesFLUX Pipeline Infer Unit Test
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/unittest/_torch/visual_gen/test_flux_infer.py`:
- Around line 1-2: The new test file currently has only the SPDX header, but new
Python source files must include the repository-mandated NVIDIA copyright block.
Update the header in the test file to use the standard NVIDIA source copyright
header required for all new .py files, keeping the SPDX license line if needed,
and ensure the file begins with the full NVIDIA copyright notice used elsewhere
in the repo.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 56f02e74-ea75-406d-a28b-b06415d5c97c
📒 Files selected for processing (2)
tests/integration/test_lists/test-db/l0_a10.ymltests/unittest/_torch/visual_gen/test_flux_infer.py
|
/bot run |
2 similar comments
|
/bot run |
|
/bot run |
…g test The existing GPU tests call forward() directly, so a regression where infer() drops num_images_per_prompt (the original TRTLLM-12870 failure mode) would still pass. Add a CPU-only stubbed test that asserts infer() forwards the parameter to forward(), parametrized over FluxPipeline and Flux2Pipeline. Register in l0_a10. Signed-off-by: Ying Guo <244492186+yingguo-trt@users.noreply.github.com>
fdc2006 to
379fed7
Compare
|
/bot run |
|
/bot run |
|
PR_Github #57376 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #57379 [ run ] triggered by Bot. Commit: |
|
PR_Github #57376 [ run ] completed with state |
|
PR_Github #57379 [ run ] completed with state |
NVIDIA#15745) Signed-off-by: Ying Guo <244492186+yingguo-trt@users.noreply.github.com>
…g test
The existing GPU tests call forward() directly, so a regression where infer() drops num_images_per_prompt (the original TRTLLM-12870 failure mode) would still pass. Add a CPU-only stubbed test that asserts infer() forwards the parameter to forward(), parametrized over FluxPipeline and Flux2Pipeline. Register in l0_a10.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.