[None][chore] Upgrade ray version to 2.55.1#15819
Conversation
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
📝 WalkthroughWalkthroughRay dependency version is bumped from 2.54.1 to 2.55.1 across Jenkins CI configuration, a Slurm install script, and a Verl integration config file. Additionally, PlacementGroupSchedulingStrategy imports are updated with version-tolerant try/except logic across executor and test files to support Ray >= 2.55.0's new import location. ChangesRay 2.55.1 Upgrade
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tensorrt_llm/executor/ray_executor.py (1)
11-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider centralizing the Ray compat import.
This try/except for
PlacementGroupSchedulingStrategyis duplicated verbatim inray_executor.py,run_rl_perf_reproduce.py,test_executor.py, andtest_multi_instance.py. A single shared compatibility shim (e.g. a smallray_compathelper) would avoid drift if the import path changes again in a future Ray release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tensorrt_llm/executor/ray_executor.py` around lines 11 - 20, The Ray compatibility import for PlacementGroupSchedulingStrategy is duplicated across ray_executor.py and the related scripts/tests, so centralize it into a shared ray_compat helper and import from there instead. Move the try/except fallback into one reusable module, then update ray_executor.py and the other callers to use that shared symbol so future Ray import-path changes only need one fix.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tensorrt_llm/executor/ray_executor.py`:
- Around line 11-20: The Ray compatibility import for
PlacementGroupSchedulingStrategy is duplicated across ray_executor.py and the
related scripts/tests, so centralize it into a shared ray_compat helper and
import from there instead. Move the try/except fallback into one reusable
module, then update ray_executor.py and the other callers to use that shared
symbol so future Ray import-path changes only need one fix.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b283933e-117b-407a-a166-00c428426ed0
📒 Files selected for processing (7)
jenkins/L0_Test.groovyjenkins/scripts/slurm_install.shtensorrt_llm/executor/ray_executor.pytests/integration/defs/ray_orchestrator/RL/run_rl_perf_reproduce.pytests/integration/defs/verl/verl_config.ymltests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.pytests/unittest/_torch/ray_orchestrator/multi_gpu/test_multi_instance.py
|
/bot run --disable-fail-fast |
|
PR_Github #56864 [ run ] triggered by Bot. Commit: |
|
PR_Github #56864 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #56928 [ run ] triggered by Bot. Commit: |
|
PR_Github #56928 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
/bot run --disable-fail-fast |
|
PR_Github #57068 [ run ] triggered by Bot. Commit: |
|
PR_Github #57068 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
1 similar comment
|
/bot run --disable-fail-fast |
|
PR_Github #57178 [ run ] triggered by Bot. Commit: |
|
PR_Github #57178 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #57201 [ run ] triggered by Bot. Commit: |
|
PR_Github #57201 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
1 similar comment
|
/bot run --disable-fail-fast |
|
PR_Github #57385 [ run ] triggered by Bot. Commit: |
|
PR_Github #57385 [ run ] completed with state |
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
4 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.