Skip to content

[None][infra] add disable-cbts flag to explicitly disable CBTS#15830

Merged
crazydemo merged 1 commit into
NVIDIA:mainfrom
crazydemo:cbts-v2
Jul 7, 2026
Merged

[None][infra] add disable-cbts flag to explicitly disable CBTS#15830
crazydemo merged 1 commit into
NVIDIA:mainfrom
crazydemo:cbts-v2

Conversation

@crazydemo

@crazydemo crazydemo commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added a user-facing option to disable CBTS for a run, allowing the full test set to execute instead of being narrowed.
    • CBTS now clearly records when it has been disabled, improving status visibility in reporting.
  • Documentation

    • Updated guidance to describe the new disable-CBTS behavior and the associated status values.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@crazydemo crazydemo requested review from a team as code owners July 1, 2026 10:52
@crazydemo crazydemo requested review from mzweilz and tburt-nv July 1, 2026 10:52
@crazydemo crazydemo requested a review from yiqingy0 July 1, 2026 10:52
@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56915 [ run ] triggered by Bot. Commit: dedf33a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56915 [ run ] completed with state SUCCESS. Commit: dedf33a
/LLM/main/L0_MergeRequest_PR pipeline #45721 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c665a0c1-32c9-4c8f-9b6a-6a5bfce0b612

📥 Commits

Reviewing files that changed from the base of the PR and between 3b5ce7c and cbd64ff.

📒 Files selected for processing (4)
  • jenkins/L0_MergeRequest.groovy
  • jenkins/L0_Test.groovy
  • jenkins/scripts/cbts/README.md
  • jenkins/scripts/cbts/tools/report_cbts_decision.py

📝 Walkthrough

Walkthrough

Adds a disable_cbts kill switch to two Jenkins pipelines (L0_MergeRequest.groovy, L0_Test.groovy) via a new DISABLE_CBTS testFilter flag. When set, getCbtsResult returns early, logs a "disabled" decision, and forces a full test run. Documentation and CLI help updated accordingly.

Changes

CBTS Kill Switch

Layer / File(s) Summary
MergeRequest pipeline disable path
jenkins/L0_MergeRequest.groovy
Adds DISABLE_CBTS field, wires it into testFilter from bot params, and adds early return with telemetry logging in getCbtsResult when the flag is set.
L0_Test testFilter wiring
jenkins/L0_Test.groovy
Adds DISABLE_CBTS field constant and default false entry in the testFilter map.
Documentation and CLI status option updates
jenkins/scripts/cbts/README.md, jenkins/scripts/cbts/tools/report_cbts_decision.py
Documents the --disable-cbts opt-out behavior and OpenSearch telemetry, and adds disabled as a valid --status value in the CLI docstring and argparse help.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant BotParam as gitlabParamsFromBot
  participant Pipeline as L0_MergeRequest
  participant CbtsFn as getCbtsResult
  participant Telemetry as _cbtsReportDecision

  BotParam->>Pipeline: disable_cbts flag
  Pipeline->>Pipeline: testFilter[DISABLE_CBTS] = flag
  Pipeline->>CbtsFn: getCbtsResult(testFilter)
  CbtsFn->>CbtsFn: check testFilter[DISABLE_CBTS]
  alt disabled
    CbtsFn->>Telemetry: record status "disabled"
    CbtsFn-->>Pipeline: return null
  end
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is mostly an unfilled template and lacks actual issue, solution, and test coverage details. Replace the template placeholders with a short Description and Test Coverage section that explains the change and how it was validated.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: adding a disable-CBTS flag to explicitly turn off CBTS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-cbts

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57730 [ run ] triggered by Bot. Commit: 5b4569a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57730 [ run ] completed with state FAILURE. Commit: 5b4569a
/LLM/main/L0_MergeRequest_PR pipeline #46439 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-cbts

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57761 [ run ] triggered by Bot. Commit: 9bc44f4 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57761 [ run ] completed with state SUCCESS. Commit: 9bc44f4
/LLM/main/L0_MergeRequest_PR pipeline #46465 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57891 [ run ] triggered by Bot. Commit: d74a5c2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57891 [ run ] completed with state FAILURE. Commit: d74a5c2
/LLM/main/L0_MergeRequest_PR pipeline #46586 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57899 [ run ] triggered by Bot. Commit: 156f008 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57899 [ run ] completed with state FAILURE. Commit: 156f008
/LLM/main/L0_MergeRequest_PR pipeline #46593 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "failure cases are not related to this PR"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57954 [ skip ] triggered by Bot. Commit: 156f008 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57954 [ skip ] completed with state SUCCESS. Commit: 156f008
Skipping testing for commit 156f008

Link to invocation

Comment thread jenkins/L0_Test.groovy Outdated
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only update an unused param"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57964 [ skip ] triggered by Bot. Commit: c35889e Link to invocation

@crazydemo crazydemo enabled auto-merge (squash) July 7, 2026 07:13
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57964 [ skip ] completed with state SUCCESS. Commit: c35889e
Skipping testing for commit c35889e

Link to invocation

@crazydemo crazydemo merged commit 0b0fd54 into NVIDIA:main Jul 7, 2026
8 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
…A#15830)

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants