[None][infra] add disable-cbts flag to explicitly disable CBTS#15830
Conversation
|
/bot run |
|
PR_Github #56915 [ run ] triggered by Bot. Commit: |
|
PR_Github #56915 [ run ] completed with state
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a ChangesCBTS Kill Switch
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant BotParam as gitlabParamsFromBot
participant Pipeline as L0_MergeRequest
participant CbtsFn as getCbtsResult
participant Telemetry as _cbtsReportDecision
BotParam->>Pipeline: disable_cbts flag
Pipeline->>Pipeline: testFilter[DISABLE_CBTS] = flag
Pipeline->>CbtsFn: getCbtsResult(testFilter)
CbtsFn->>CbtsFn: check testFilter[DISABLE_CBTS]
alt disabled
CbtsFn->>Telemetry: record status "disabled"
CbtsFn-->>Pipeline: return null
end
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-cbts |
|
PR_Github #57730 [ run ] triggered by Bot. Commit: |
|
PR_Github #57730 [ run ] completed with state
|
|
/bot run --disable-cbts |
|
PR_Github #57761 [ run ] triggered by Bot. Commit: |
|
PR_Github #57761 [ run ] completed with state
|
|
/bot run |
|
PR_Github #57891 [ run ] triggered by Bot. Commit: |
|
PR_Github #57891 [ run ] completed with state
|
|
/bot run |
|
PR_Github #57899 [ run ] triggered by Bot. Commit: |
|
PR_Github #57899 [ run ] completed with state
|
|
/bot skip --comment "failure cases are not related to this PR" |
|
PR_Github #57954 [ skip ] triggered by Bot. Commit: |
|
PR_Github #57954 [ skip ] completed with state |
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
|
/bot skip --comment "only update an unused param" |
|
PR_Github #57964 [ skip ] triggered by Bot. Commit: |
|
PR_Github #57964 [ skip ] completed with state |
…A#15830) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Summary by CodeRabbit
New Features
Documentation
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.