[https://nvbugs/6337231][fix] Unskip and fix iter-stats unit tests' fake-self predicate#15927
Conversation
…ake-self predicate The dummy-request predicate was promoted to a staticmethod by NVIDIA#14922 but the tests' MagicMock fake self resolves `_is_stats_dummy_request` to an auto-generated (always-truthy) child Mock, so every request was filtered as dummy and all per-request aggregates asserted 0. Bind the real predicate onto the fake self and remove the skip markers added by NVIDIA#15368. Also fixes https://nvbugs/6337233 (same root cause). Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoved pytest skip decorators and constants from several stat-aggregation tests, and fixed the ChangesTest fix for dummy request stats
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #57476 [ run ] triggered by Bot. Commit: |
|
@tedzhouhk |
lgtm, thx for fixing (sorry I can't approve due to permission reason |
|
PR_Github #57476 [ run ] completed with state |
All 9 previously skipped test cases are now covered again and have passed. |
…ake-self predicate (NVIDIA#15927) Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
The dummy-request predicate was promoted to a staticmethod by #14922 but the
tests' MagicMock fake self resolves
_is_stats_dummy_requestto anauto-generated (always-truthy) child Mock, so every request was filtered as
dummy and all per-request aggregates asserted 0. Bind the real predicate onto
the fake self and remove the skip markers added by #15368.
Also fixes https://nvbugs/6337233 (same root cause).
Summary by CodeRabbit
Bug Fixes
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.