Skip to content

[None][ci] Use x86 daemon host in Slurm jobs everywhere#15942

Merged
chzblych merged 1 commit into
mainfrom
user/yanchaol/hotfix
Jul 5, 2026
Merged

[None][ci] Use x86 daemon host in Slurm jobs everywhere#15942
chzblych merged 1 commit into
mainfrom
user/yanchaol/hotfix

Conversation

@chzblych

@chzblych chzblych commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated SBSA SLURM test jobs in the AARCH64 path to run on Kubernetes pods using amd64, aligning the test environment with the expected architecture for both single-node and multi-node runs.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych chzblych requested review from a team as code owners July 5, 2026 02:56
@chzblych chzblych requested review from dpitman-nvda and niukuo July 5, 2026 02:56
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2e427fc9-5996-4ff4-baa2-3e921239723c

📥 Commits

Reviewing files that changed from the base of the PR and between 3b08b19 and 315bb42.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy

📝 Walkthrough

Walkthrough

The pull request modifies jenkins/L0_Test.groovy to change the Kubernetes pod architecture used by SLURM dispatcher pods in AARCH64 SBSA test jobs, switching from arm64 to amd64 in the createKubernetesPodConfig calls for both parallelSlurmJobs and parallelMultiNodesSBSAJobs.

Changes

SLURM pod arch update

Layer / File(s) Summary
Update SLURM dispatcher pod architecture
jenkins/L0_Test.groovy
Both parallelSlurmJobs and parallelMultiNodesSBSAJobs change their createKubernetesPodConfig(..., "slurm", ...) argument from "arm64" to "amd64".

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is still the template text and lacks a real issue, solution, and test coverage details. Replace the placeholder template with a brief Description and Test Coverage summary, and keep the checklist filled out with PR-specific details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the CI/Slurm architecture change and is specific enough to identify the main update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch user/yanchaol/hotfix

Comment @coderabbitai help to get the list of available commands.

@chzblych

chzblych commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "GB300-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-PerfSanity-1" --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57589 [ run ] triggered by Bot. Commit: 315bb42 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57589 [ run ] completed with state SUCCESS. Commit: 315bb42
/LLM/main/L0_MergeRequest_PR pipeline #46314 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@chzblych

chzblych commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator Author

Partial testing is sufficient.

@chzblych chzblych merged commit 5adff55 into main Jul 5, 2026
16 of 18 checks passed
@chzblych chzblych deleted the user/yanchaol/hotfix branch July 5, 2026 07:09
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants