Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 46666#16100

Merged
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/waive_cases
Jul 8, 2026
Merged

[None][infra] Waive 1 failed cases for main in pre-merge 46666#16100
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/waive_cases

Conversation

@nv-guomingz

@nv-guomingz nv-guomingz commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Bug(s): 6425441
Requested by: @tianyuxbear

Summary by CodeRabbit

  • Chores
    • Updated the test waiver list to skip two attention-related test cases.
    • These changes help keep integration test runs stable while known issues are being tracked.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Bug(s): 6425441
Requested by: @tianyuxbear

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@nv-guomingz

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "update waives.txt"

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 83a6a290-367e-406f-bc07-58e9f606d1b1

📥 Commits

Reviewing files that changed from the base of the PR and between 73d3abc and 7dccd84.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This change adds two new SKIP entries to the test waiver list, excluding two specific test cases in test_attention_op_sync.py, each referencing an associated NVBUG.

Changes

Test Waiver Update

Layer / File(s) Summary
Add skip entries
tests/integration/test_lists/waives.txt
Adds two SKIP entries for test_attr_kwarg_names_match_source_leaf_attrs_except_allowlisted_aliases and test_every_forward_args_field_is_consumed in test_attention_op_sync.py, each with an NVBUG reference.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: mzweilz

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The required template is included, but the Description and Test Coverage sections are effectively empty. Add a short description of the issue and waiver change, plus the tests or CI coverage that validate these updated skips.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is aligned with the waiver change and uses the required ticket/type format, though the count is a bit imprecise.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58146 [ skip ] triggered by Bot. Commit: 7dccd84 Link to invocation

@nv-guomingz nv-guomingz enabled auto-merge (squash) July 8, 2026 04:53
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58146 [ skip ] completed with state SUCCESS. Commit: 7dccd84
Skipping testing for commit 7dccd84

Link to invocation

@nv-guomingz nv-guomingz merged commit 3eb7feb into NVIDIA:main Jul 8, 2026
14 of 15 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
…A#16100)

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants