[None][test] Add deepseek v4 pro cases on the qa side#16611
Conversation
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot skip --comment "Only add deepseek cases for the qa side" |
📝 WalkthroughWalkthroughAdded GB300 DeepSeek-V4-Pro disaggregated benchmark configurations, fixed MoE load-balancer fixtures, and four QA performance test entries for disaggregated and multinode runs. ChangesDeepSeek-V4-Pro performance coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@tests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_ctx_ep4_384.yaml`:
- Line 1: Add the repository-standard NVIDIA copyright header at the beginning
of each affected YAML file, before its existing top-level key:
tests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_ctx_ep4_384.yaml
(lines 1-1),
tests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep16_slots384.yaml
(lines 1-1),
tests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep16_slots416.yaml
(lines 1-1),
tests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep32_slots384.yaml
(lines 1-1),
tests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con666_ctx6_dep4_gen1_dep16_eplb384_mtp3_ccb-NIXL.yaml
(lines 1-1), and
tests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con8_ctx1_dep4_gen4_tep8_eplb0_mtp3_ccb-NIXL.yaml
(lines 1-1).
In
`@tests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep32_slots416.yaml`:
- Line 1: Prepend the standard NVIDIA copyright header to each affected YAML
file:
tests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep32_slots416.yaml,
moe_load_balancer_gen_ep4_slots384.yaml,
moe_load_balancer_gen_ep4_slots416.yaml,
moe_load_balancer_gen_ep8_slots384.yaml,
moe_load_balancer_gen_ep8_slots416.yaml, and the two gb300_deepseek-v4-pro YAML
files listed in the review. Keep the existing initial_global_assignments content
unchanged after the header.
In
`@tests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con180_ctx3_dep4_gen1_dep32_eplb384_mtp3_ccb-NIXL.yaml`:
- Around line 17-27: Replace the <dataset_file> placeholder with a concrete,
resolvable dataset path in the benchmark configuration at
tests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con180_ctx3_dep4_gen1_dep32_eplb384_mtp3_ccb-NIXL.yaml
lines 17-27 and the sibling configuration at
tests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con4301_ctx12_dep4_gen1_dep8_eplb384_mtp1_ccb-NIXL.yaml
lines 17-27. Keep the existing benchmark settings unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 825e6e97-6979-48d3-b1d0-4f01cf913555
📒 Files selected for processing (15)
tests/integration/test_lists/qa/llm_perf_disagg.ymltests/integration/test_lists/qa/llm_perf_multinode.txttests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_ctx_ep4_384.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep16_slots384.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep16_slots416.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep32_slots384.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep32_slots416.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep4_slots384.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep4_slots416.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep8_slots384.yamltests/scripts/perf/disaggregated/deepseek-v4-pro-eplb/moe_load_balancer_gen_ep8_slots416.yamltests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con180_ctx3_dep4_gen1_dep32_eplb384_mtp3_ccb-NIXL.yamltests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con4301_ctx12_dep4_gen1_dep8_eplb384_mtp1_ccb-NIXL.yamltests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con666_ctx6_dep4_gen1_dep16_eplb384_mtp3_ccb-NIXL.yamltests/scripts/perf/disaggregated/gb300_deepseek-v4-pro-fp4_8k1k_con8_ctx1_dep4_gen4_tep8_eplb0_mtp3_ccb-NIXL.yaml
|
PR_Github #60338 [ skip ] triggered by Bot. Commit: |
|
PR_Github #60338 [ skip ] completed with state |
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
…to feature/add_deepseek_v4_4_qa
|
/bot skip --comment "Only add deepseek cases for the qa side" |
|
PR_Github #60594 [ skip ] triggered by Bot. Commit: |
|
PR_Github #60594 [ skip ] completed with state |
Summary by CodeRabbit
New Performance Coverage
Tests
Add deepseek v4 pro cases on the qa side.