[None][chore] update DeepGEMM to 2.6.1 - #16673
Conversation
7532f36 to
23a5473
Compare
|
/bot run |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughDeepGEMM is updated to a new revision, attribution mappings are synchronized, fused TF32 pmap kernels use updated DeepGEMM namespaces and descriptor helpers, and MegaMoE supplies expanded SymmBuffer allocation arguments. ChangesDeepGEMM integration update
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #60741 [ run ] triggered by Bot. Commit: |
|
PR_Github #60741 [ run ] completed with state
|
23a5473 to
7e3c861
Compare
|
/bot run |
|
PR_Github #60900 [ run ] triggered by Bot. Commit: |
|
PR_Github #60900 [ run ] completed with state
|
7e3c861 to
62cb1aa
Compare
|
/bot run |
|
PR_Github #61147 [ run ] triggered by Bot. Commit: |
|
PR_Github #61147 [ run ] completed with state
|
512c6e9 to
4106f8b
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #61313 [ run ] triggered by Bot. Commit: |
|
PR_Github #61313 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61426 [ run ] completed with state
|
4106f8b to
8e999ba
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #61767 [ run ] triggered by Bot. Commit: |
|
PR_Github #61767 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61838 [ run ] triggered by Bot. Commit: |
|
PR_Github #61838 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61893 [ run ] triggered by Bot. Commit: |
|
PR_Github #61893 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
8e999ba to
ffc23b8
Compare
|
PR_Github #61955 [ run ] triggered by Bot. Commit: |
|
PR_Github #61955 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #62302 [ run ] triggered by Bot. Commit: |
|
PR_Github #62302 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #62446 [ run ] triggered by Bot. Commit: |
|
PR_Github #62446 [ run ] completed with state |
Summary
Update the bundled DeepGEMM from 2.5.0 (
245dc5d) to 2.6.1 (f8e8fb5).Validation
d75cb89a0e.git diff --check: passed.MegaMoE performance
MegaMoE EP8 microbenchmark on 8x B200, using
e384/k6/h7168/i3072, FP8xFP4, no shared expert, and A1/B1/B2/A2 ordering. Each cell contains six repeated outer samples, with each sample averaging ten kernel launches. Lower latency is better.Values are median +/- MAD. The symmetric buffer decreased from 6.772 GiB to 1.716 GiB (3.95x smaller). Fixed rank-0 output samples were finite, deterministic within each run, and byte-identical across versions for both tested shapes.
Dev Engineer Review
3rdparty/fetch_content.json) and refreshed DeepGEMM attribution/build-input hash mappings (scripts/attribution/data/dependency_metadata.yml,scripts/attribution/data/files_to_dependency.yml), including the DeepGEMM PR#384fix for an SM100 MQA kernel synchronization/ordering race.cpp/tensorrt_llm/kernels/mhcKernels/fused_tf32_pmap_gemm.cuhto match DeepGEMM’s new header/namespace layout:tma_copyhelper/alias usage and switched TMA tile transfers to fully-qualifieddeep_gemm::tma::copy<...>(...)call sites for theresidualandBtiles.x_vals/r_valsfromdeep_gemm::sm90::...::copytodeep_gemm::ptx::...::copy.makeBUmmaDescriptor/advanceBUmmaDescriptorLousage.tensorrt_llm/_torch/modules/fused_moe/mega_moe/mega_moe_deepgemm.pyto pass required DeepGEMM allocation configuration (num_shared_experts=0,mma_type="fp8xfp4") and changed theactivationargument to keyword form (activation=self.activation).23a5473(pipeline#49028),7e3c861(pipeline#49168), and62cb1aa(pipeline#49395); each requested review/fixes of failing tests and reruns (after NVIDIA-team-triggered attempts).QA Engineer Review
No test changes.