[https://nvbugs/6501394][fix] Amend the attempt 0 commit to also delete the single waives.txt line…#16840
Open
trtllm-agent wants to merge 1 commit into
Open
[https://nvbugs/6501394][fix] Amend the attempt 0 commit to also delete the single waives.txt line…#16840trtllm-agent wants to merge 1 commit into
trtllm-agent wants to merge 1 commit into
Conversation
…l Linear After NVIDIA#14875 ("Uneven TP Linear for VisualGen models") landed, ROW-parallel Linear with hidden_size not divisible by tp_size now works correctly via _auto_tp_sharding + _calc_shard. For hidden_size=15, tp_size=2 both torch.chunk(x, 2, dim=-1) and _calc_shard produce sizes [8, 7], and the subsequent AllReduce reconstructs the full output. Consequently the row_linear_forward accuracy check now passes for odd hidden sizes. The remaining "if hidden_size % 2 != 0: pytest.raises(AssertionError)" branch in test_row_linear is stale and produces "Failed: DID NOT RAISE". Assert unconditionally, matching the pattern already used by test_mlp / test_row_linear_norm_fusion / test_fp4_row_linear_allreduce. Signed-off-by: handongl <handongl@nvidia.com>
trtllm-agent
requested review from
QiJune,
StanleySun639,
schetlur-nv,
tburt-nv and
yuanjingx87
July 24, 2026 14:19
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughChangesRow-linear validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest.raises(AssertionError)guard triggers "DID NOT RAISE"; the test's waiver in waives.txt (line 355) still skips it in CI.unittest/_torch/multi_gpu/test_linear.py::test_row_linear[2-unbalanced] SKIP (https://nvbugs/6501394); leave adjacent lines (6507113, 6501404) untouched — they are different NVBugs.Test plan
Links
Dev Engineer Review
test_row_linear[2-unbalanced].test_row_linearto assert successful execution for odd hidden sizes unconditionally.QA Engineer Review
test_row_linearintests/unittest/_torch/multi_gpu/test_linear.py.test-db/orqa/entry; only its waiver entry was removed fromwaives.txt.