[https://nvbugs/6528742][test] Disable V2 in legacy Mamba test - #17049
Merged
VALLIS-NERIA merged 1 commit intoAug 3, 2026
Merged
Conversation
…ent) Signed-off-by: Xiwen Yu <13230610+VALLIS-NERIA@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #62722 [ run ] triggered by Bot. Commit: |
VALLIS-NERIA
marked this pull request as ready for review
July 30, 2026 06:51
VALLIS-NERIA
requested review from
BowenFu,
QiJune,
ZhanruiSunCh,
ruodil,
yingguo-trt and
yuanjingx87
July 30, 2026 06:51
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe FP8 four-GPU Nemotron test now explicitly disables KV-cache-manager-v2 in its ChangesKV Cache Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
PR_Github #62722 [ run ] completed with state |
BowenFu
approved these changes
Jul 30, 2026
yingguo-trt
approved these changes
Jul 31, 2026
1 task
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
KvCacheConfig.use_kv_cache_manager_v2=Falsein the parameterized Nemotron V3 Super legacy Mamba cache manager test.Why
The model defaults can otherwise select
MambaHybridCacheManagerV2, even when the test setsTRTLLM_USE_PY_MAMBA=1. This made thepython_mamba_cachecase stop exercising the intended legacyMixedMambaHybridCacheManager.Pinning V2 off keeps both legacy Python and C++ manager parameterizations on their intended paths.
Validation
pre-commit run --files tests/integration/defs/accuracy/test_llm_api_pytorch.pypytest tests/unittest/_torch/executor/test_mamba_cache_manager.py -k hybrid_cache_manager_factory_honors_v2_setting— 4 passedTestNemotronV3Super::test_fp8_4gpus[attention_dp_on-python_mamba_cache]— passedMixedMambaHybridCacheManagerDev Engineer Review
test_fp8_4gpusto explicitly setKvCacheConfig.use_kv_cache_manager_v2=False, ensuring the test exercises the intended legacy Mamba cache manager regardless of model defaults orTRTLLM_USE_PY_MAMBA.QA Engineer Review
test_fp8_4gpusintests/integration/defs/accuracy/test_llm_api_pytorch.py.