Skip to content

[None][test] Add back new ctx and gen only case - #17101

Merged
fredricz-20070104 merged 3 commits into
NVIDIA:mainfrom
fredricz-20070104:feature/addback_gen_only_and_ctx_only
Aug 3, 2026
Merged

[None][test] Add back new ctx and gen only case#17101
fredricz-20070104 merged 3 commits into
NVIDIA:mainfrom
fredricz-20070104:feature/addback_gen_only_and_ctx_only

Conversation

@fredricz-20070104

@fredricz-20070104 fredricz-20070104 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated tests/integration/test_lists/qa/llm_perf_multinode.txt.
  • Added aggregated multi-node ctx_only coverage for two GB200 DeepSeek-R1 configurations.
  • Added gen_only coverage for five GB200/GB300 configurations.
  • The entries cover DeepSeek-R1, GPT-OSS-120B, Kimi-K2.5-Thinking, wideep DeepSeek-R1, and GLM-5.
  • The change restores the intended context-only and generation-only coverage.
  • No exported or public entities changed.
  • The test-list format and scope require verification against the repository diff and related entries.

QA Engineer Review

  • Modified file: tests/integration/test_lists/qa/llm_perf_multinode.txt.
  • Added two ctx_only entries and five gen_only entries.
  • Replaced the previous empty gen_only section.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Add back new ctx and gen only case

Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6e51894b-b907-4cf9-9292-52014918cd78

📥 Commits

Reviewing files that changed from the base of the PR and between 138eb43 and 8d6ba96.

📒 Files selected for processing (1)
  • tests/integration/test_lists/qa/llm_perf_multinode.txt

Walkthrough

The multi-node performance test list adds two aggregated ctx_only cases and five gen_only cases for GB200 and GB300 configurations covering several language models.

Changes

Multi-node performance coverage

Layer / File(s) Summary
Add multi-node coverage
tests/integration/test_lists/qa/llm_perf_multinode.txt
Adds two aggr-ctx_only tests and five disagg-gen_only tests. The gen_only section now contains executable configurations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: yufeiwu-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only states the change and omits the required issue explanation, test coverage, and checklist review. Add the required Description and Test Coverage sections, and complete the PR Checklist with relevant confirmations.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the test change and follows the repository's ticket and type format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@fredricz-20070104
fredricz-20070104 enabled auto-merge (squash) August 3, 2026 01:02
@fredricz-20070104

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "skip test as just modify some test configs, only run in qa side"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63375 [ skip ] triggered by Bot. Commit: 504f5cf Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63375 [ skip ] completed with state SUCCESS. Commit: 504f5cf
Skipping testing for commit 504f5cf

Link to invocation

@fredricz-20070104
fredricz-20070104 merged commit 3733554 into NVIDIA:main Aug 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants