[None][fix] Restore CTX transfer progress when scheduling stalls - #17343
Closed
peihu-nv wants to merge 1 commit into
Closed
[None][fix] Restore CTX transfer progress when scheduling stalls#17343peihu-nv wants to merge 1 commit into
peihu-nv wants to merge 1 commit into
Conversation
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
peihu-nv
force-pushed
the
peihengh/m3-disagg-idle-reap-fix-20260805
branch
from
August 6, 2026 17:21
2cd7a1e to
d0595c5
Compare
peihu-nv
marked this pull request as ready for review
August 6, 2026 17:26
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #64386 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #64386 [ run ] completed with state |
Collaborator
Author
|
New PR aligned with main #17428 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
PR #17104 removed the disaggregated transfer admission limit and its per-iteration idle-progress collectives. When a context worker subsequently exhausted available KV capacity while sends were still in flight, no forward could run, so the normal nonblocking completion poll became unreachable. The completed sends continued pinning their KV blocks and the worker could stall indefinitely.
Keep unrestricted transfer admission, but restore a targeted blocking completion poll only when no request fits, no generation-init request is ready, and a context transfer is still in flight. The existing transfer-status path performs the required completion consensus and releases the pinned blocks; normal executor iterations retain the collective-free fast path.
Test Coverage
TestDisaggTransferIdleProgresssuite passes: 11 passed. It covers the zero-fit/in-flight context-transfer condition and verifies that the existing blocking context-status poll is entered without restoring the removed WORLD or TP/CP entry collectives.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.