Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 52592 - #17443

Merged
dominicshanshan merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260809-063646
Aug 9, 2026
Merged

[None][infra] Waive 1 failed cases for main in pre-merge 52592#17443
dominicshanshan merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260809-063646

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @dominicshanshan)
Target branch: main
Bug(s): 6578853

Waive entries added

unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1] SKIP (https://nvbugs/6578853)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added one waiver for unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].
  • Associated the waiver with nvbugs issue 6578853.
  • The change is limited to tests/integration/test_lists/waives.txt.
  • No public entities or APIs changed.
  • Waiver format and scope are appropriate.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Added one CI waiver entry.
  • CBTS coverage data is unavailable.

Verdict: needs follow-up.

Bug(s): 6578853
Requested by: @dominicshanshan

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The integration waiver list now skips test_performance_alignment[1] in test_layer_wise_benchmarks.py and links the waiver to nvbugs issue 6578853.

Changes

Benchmark test waiver

Layer / File(s) Summary
Add benchmark waiver
tests/integration/test_lists/waives.txt
Adds a skip record for the layer-wise benchmark performance-alignment test and references nvbugs issue 6578853.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: ci: full pre-merge approved

Suggested reviewers: brnguyen2, qijune

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the infrastructure change: waiving one failed case on the main branch.
Description check ✅ Passed The description identifies the failed test, waiver reason, bug ID, target branch, and requested change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)

1-1: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Update waiver parsing before adding the copyright header.

Add the 2026 NVIDIA SPDX header after verify_waive_list ignores # comment lines. The current verifier treats header lines as nonexistent test names, while the integration parser ignores them. The waiver entry is already listed in test-db/l0_b200.yml.

Coverage summary: no test-code changes; no test-db/ or qa/ files changed. One waiver entry was added. Coverage verdict: needs follow-up because no CBTS artifact is available.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 1, Update verify_waive_list
to ignore lines beginning with # when parsing waivers, matching the integration
parser’s behavior. Then add the 2026 NVIDIA SPDX copyright header to waives.txt,
ensuring it is treated as a comment rather than a test name and preserving the
existing waiver entry.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 1: Update verify_waive_list to ignore lines beginning with # when parsing
waivers, matching the integration parser’s behavior. Then add the 2026 NVIDIA
SPDX copyright header to waives.txt, ensuring it is treated as a comment rather
than a test name and preserving the existing waiver entry.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 43bae39c-784b-41da-92ab-703965a2a3ce

📥 Commits

Reviewing files that changed from the base of the PR and between 1d7c771 and ee0151a.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

@dominicshanshan

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64831 [ skip ] triggered by Bot. Commit: ee0151a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64831 [ skip ] completed with state SUCCESS. Commit: ee0151a
Skipping testing for commit ee0151a

Link to invocation

@dominicshanshan
dominicshanshan merged commit cc678cd into NVIDIA:main Aug 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants