[None][test] Waive 2 failed cases for main in QA CI - #17468
Conversation
Bug(s): 6546909, 6580087 Requested by: qa@nvidia.com Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "Only waive tests" |
WalkthroughAdded two H20 test waivers for Llama 3.1 8B FP8 TRTLLM configurations. The entries cover single-GPU and four-GPU tests with ChangesH20 Llama FP8 waivers
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 280-281: Add the repository-standard NVIDIA copyright header at
the beginning of tests/integration/test_lists/waives.txt, using 2026 as the
latest meaningful year, while preserving the existing waiver entries unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a61d63ab-61ec-47f7-bc7a-3fc3554a43fc
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
| full:H20/accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8[fp8kv=False-attn_backend=TRTLLM-torch_compile=True] SKIP (https://nvbugs/6546909) | ||
| full:H20/accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8_4gpus[tp4-fp8kv=False-attn_backend=TRTLLM-torch_compile=True] SKIP (https://nvbugs/6580087) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Add the required NVIDIA copyright header.
The provided tests/integration/test_lists/waives.txt content starts with a waiver entry and contains no NVIDIA copyright header. Add the repository-standard header and set its year to 2026.
As per coding guidelines, **/* requires an NVIDIA copyright header on all files and the latest meaningful year on modified files.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tests/integration/test_lists/waives.txt` around lines 280 - 281, Add the
repository-standard NVIDIA copyright header at the beginning of
tests/integration/test_lists/waives.txt, using 2026 as the latest meaningful
year, while preserving the existing waiver entries unchanged.
Source: Coding guidelines
|
PR_Github #65009 [ skip ] triggered by Bot. Commit: |
|
PR_Github #65009 [ skip ] completed with state |
brnguyen2
left a comment
There was a problem hiding this comment.
Test IDs match the parametrize decorators, no duplicate entries, placement in the H20 block is consistent. LGTM.
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainBug(s): 6546909, 6580087
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
SKIPwaivers intests/integration/test_lists/waives.txt.torch_compile=True,fp8kv=False, and bug references6546909and6580087.QA Engineer Review
tests/integration/test_lists/waives.txt.test-db/orqa/files were modified.