Skip to content

[None][test] Waive 2 failed cases for main in QA CI - #17468

Open
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260810-094518
Open

[None][test] Waive 2 failed cases for main in QA CI#17468
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260810-094518

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch: main
Bug(s): 6546909, 6580087

Waive entries added

full:H20/accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8_4gpus[tp4-fp8kv=False-attn_backend=TRTLLM-torch_compile=True] SKIP (https://nvbugs/6580087)
full:H20/accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8[fp8kv=False-attn_backend=TRTLLM-torch_compile=True] SKIP (https://nvbugs/6546909)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added two SKIP waivers in tests/integration/test_lists/waives.txt.
  • Covers the H20 Llama 3.1 8B Instruct FP8 tests for one GPU and four GPUs.
  • Entries include torch_compile=True, fp8kv=False, and bug references 6546909 and 6580087.
  • No public API or production code changes.
  • No duplicate or unintended scope changes identified.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Added two waiver entries.
  • No test-db/ or qa/ files were modified.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Bug(s): 6546909, 6580087
Requested by: qa@nvidia.com

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@jieli-matrix
jieli-matrix enabled auto-merge (squash) August 10, 2026 09:45
@jieli-matrix

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Only waive tests"

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Added two H20 test waivers for Llama 3.1 8B FP8 TRTLLM configurations. The entries cover single-GPU and four-GPU tests with torch_compile=True and fp8kv=False.

Changes

H20 Llama FP8 waivers

Layer / File(s) Summary
Add H20 waiver entries
tests/integration/test_lists/waives.txt
Adds waivers for single-GPU and four-GPU Llama 3.1 8B FP8 TRTLLM tests. Each entry references an NVBUG issue.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: qijune, schetlur-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the test waiver change and the target branch.
Description check ✅ Passed The description explains the waiver purpose, lists both affected test cases, and links the associated bugs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 280-281: Add the repository-standard NVIDIA copyright header at
the beginning of tests/integration/test_lists/waives.txt, using 2026 as the
latest meaningful year, while preserving the existing waiver entries unchanged.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a61d63ab-61ec-47f7-bc7a-3fc3554a43fc

📥 Commits

Reviewing files that changed from the base of the PR and between 67dd1b7 and acdfff0.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment on lines +280 to +281
full:H20/accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8[fp8kv=False-attn_backend=TRTLLM-torch_compile=True] SKIP (https://nvbugs/6546909)
full:H20/accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8_4gpus[tp4-fp8kv=False-attn_backend=TRTLLM-torch_compile=True] SKIP (https://nvbugs/6580087)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Add the required NVIDIA copyright header.

The provided tests/integration/test_lists/waives.txt content starts with a waiver entry and contains no NVIDIA copyright header. Add the repository-standard header and set its year to 2026.

As per coding guidelines, **/* requires an NVIDIA copyright header on all files and the latest meaningful year on modified files.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` around lines 280 - 281, Add the
repository-standard NVIDIA copyright header at the beginning of
tests/integration/test_lists/waives.txt, using 2026 as the latest meaningful
year, while preserving the existing waiver entries unchanged.

Source: Coding guidelines

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65009 [ skip ] triggered by Bot. Commit: acdfff0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65009 [ skip ] completed with state SUCCESS. Commit: acdfff0
Skipping testing for commit acdfff0

Link to invocation

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test IDs match the parametrize decorators, no duplicate entries, placement in the H20 block is consistent. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants