[#9632][feat] Support EXTRA_WHEEL_BUILD_ARGS during wheel build

[michael132]

Summary by CodeRabbit

• Chores
  • Enhanced wheel build process to support custom build arguments via environment variables, enabling greater flexibility in build configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Support the use of EXTRA_WHEEL_BUILD_ARGS during wheel build to allow more options, specifying build-number for example, without the need to post-process/hack the wheel name.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

closes #9632

[coderabbitai]

📝 Walkthrough

Walkthrough

The change enables dynamic specification of additional wheel build options by reading the EXTRA_WHEEL_BUILD_ARGS environment variable and inserting its value into the wheel build command invocation. This allows external arguments to be passed to the build process without modifying the script directly.

Changes

Cohort / File(s)	Summary
Environment-based build arguments scripts/build_wheel.py	Added reading of EXTRA_WHEEL_BUILD_ARGS environment variable and integrated its value into the wheel build command, enabling dynamic injection of additional build options.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify that the environment variable is read correctly using os.getenv() with appropriate default fallback
• Confirm the arguments are properly inserted into the command string at the correct position (after --skip-dependency-check)
• Check that existing build arguments (--no-isolation, --outdir) remain unaffected
• Ensure no shell injection vulnerabilities when external arguments are incorporated

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The code change directly implements the feature requested in #9632 by reading EXTRA_WHEEL_BUILD_ARGS from the environment and inserting it into the wheel build command.
Out of Scope Changes check	✅ Passed	All changes are scoped to implementing the EXTRA_WHEEL_BUILD_ARGS feature requested in issue #9632, with only the wheel build script modified.
Description check	✅ Passed	The PR description includes a clear explanation of the feature (support for EXTRA_WHEEL_BUILD_ARGS), its purpose (allow extra options without post-processing), and explicitly acknowledges that test coverage is N/A.
Title check	✅ Passed	The title accurately describes the main change: adding support for the EXTRA_WHEEL_BUILD_ARGS environment variable during wheel build, which directly matches the file modifications in scripts/build_wheel.py.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

scripts/build_wheel.py (1)

949-951: EXTRA_WHEEL_BUILD_ARGS integration looks correct; consider light sanitization/logging

The new EXTRA_WHEEL_BUILD_ARGS handling does what the issue asks: it cleanly splices arbitrary extra options into the python -m build invocation after --skip-dependency-check, preserving the rest of the flags. Behavior on an unset var is also fine (just an extra space).

As a minor hardening / ergonomics tweak, you could:

• Strip whitespace to avoid accidental leading/trailing spaces, and
• Optionally log the effective extra args for debugging failed builds, especially since this is interpolated into a shell=True command.

For example:

-        extra_wheel_build_args = os.getenv("EXTRA_WHEEL_BUILD_ARGS", "")
+        extra_wheel_build_args = os.getenv("EXTRA_WHEEL_BUILD_ARGS", "").strip()
+        if extra_wheel_build_args:
+            print(f"-- Using EXTRA_WHEEL_BUILD_ARGS: {extra_wheel_build_args}")

This keeps current behavior while making misconfigurations easier to spot and slightly reducing the chance of surprising shell parsing issues.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3991aa9 and 3268810.

📒 Files selected for processing (1)

• scripts/build_wheel.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+
Indent Python code with 4 spaces; do not use tabs
Always maintain the namespace when importing in Python, even if only one class or function from a module is used (e.g., use from package.subpackage import foo and then foo.SomeClass() instead of from package.subpackage.foo import SomeClass)
Python filenames should use snake_case (e.g., some_file.py)
Python class names should use PascalCase (e.g., class SomeClass)
Python function and method names should use snake_case (e.g., def my_awesome_function():)
Python local variable names should use snake_case, with prefix k for variable names that start with a number (e.g., k_99th_percentile = ...)
Python global variables should use upper snake_case with prefix G (e.g., G_MY_GLOBAL = ...)
Python constants should use upper snake_case (e.g., MY_CONSTANT = ...)
Avoid shadowing variables declared in an outer scope in Python
Initialize all externally visible members of a Python class in the constructor
For Python interfaces that may be used outside a file, prefer docstrings over comments
Python comments should be reserved for code within a function, or interfaces that are local to a file
Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx
Python attributes and variables can be documented inline with type and description (e.g., self.x = 5 followed by """<type>: Description of 'x'""" )
Avoid using reflection in Python when functionality can be easily achieved without reflection
When using try-except blocks in Python, limit the except clause to the smallest set of specific errors possible instead of catching all exceptions
When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible and use the else block to implement the logic

Files:

• scripts/build_wheel.py

**/*.{cpp,h,cu,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

All TensorRT-LLM Open Source Software code files should contain an NVIDIA copyright header that includes the current year at the top

Files:

• scripts/build_wheel.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

[yuanjingx87]

/bot run

[tensorrt-cicd]

PR_Github #26652 [ run ] triggered by Bot. Commit: e9ff836

[tensorrt-cicd]

PR_Github #26652 [ run ] completed with state SUCCESS. Commit: e9ff836
/LLM/main/L0_MergeRequest_PR pipeline #20278 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.