Skip to content

[PyTorch] Port fused optimizer tests to pytest#1185

Merged
timmoon10 merged 1 commit into
NVIDIA:mainfrom
timmoon10:pytest-optim-tests
Sep 18, 2024
Merged

[PyTorch] Port fused optimizer tests to pytest#1185
timmoon10 merged 1 commit into
NVIDIA:mainfrom
timmoon10:pytest-optim-tests

Conversation

@timmoon10
Copy link
Copy Markdown
Member

Description

The fused optimizers from Apex (see #867) included unittest tests. This PR ports them to pytest so they will run in our CI pipelines.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor
  • Testing

Changes

  • Port fused optimizer tests from unittest to pytest

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added the testing Improvements to tests or testing infrastructure label Sep 16, 2024
@timmoon10
Copy link
Copy Markdown
Member Author

/te-ci pytorch

Copy link
Copy Markdown
Member

@yaox12 yaox12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timmoon10 timmoon10 merged commit 7e1068b into NVIDIA:main Sep 18, 2024
@timmoon10 timmoon10 deleted the pytest-optim-tests branch September 18, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Improvements to tests or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants