[PyTorch] Move FusedAdam/FusedSGD and necessary kernels from Apex to TE#867
Merged
Conversation
Member
|
/te-ci pytorch |
Signed-off-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Member
|
/te-ci pytorch |
Member
Author
|
@timmoon10 Can I get this PR merged if it looks good to you? It's sufficient to be a drop-in replacement of Apex.FusedAdam in MCore. Other features to be migrated or implemented will come in separate PRs. |
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
timmoon10
approved these changes
May 30, 2024
Member
timmoon10
left a comment
There was a problem hiding this comment.
LGTM, I confirm this is mostly copy-pasted from Apex with some minor formatting changes.
14 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves
FusedAdam/FusedSGDand necessarymulti_tensor_*kernels from Apex to TE, as well as the tests.Type of change
Changes
Please list the changes introduced in this PR:
multi_tensor_*kernelsFusedAdamFusedSGDChecklist: