Skip to content

Added new users to CI - #2756

Merged
ptrendx merged 2 commits into
NVIDIA:mainfrom
ptrendx:pr_add_people_to_ci
Mar 12, 2026
Merged

Added new users to CI#2756
ptrendx merged 2 commits into
NVIDIA:mainfrom
ptrendx:pr_add_people_to_ci

Conversation

@ptrendx

@ptrendx ptrendx commented Mar 12, 2026

Copy link
Copy Markdown
Member

Description

Added @pstjohn @cspades @jomitchellnv to CI trigger.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx requested a review from ksivaman March 12, 2026 21:30
@greptile-apps

greptile-apps Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds two new GitHub users — cspades and jomitchellnv — to the allowlist in the CI trigger workflow, enabling them to trigger CI runs by commenting /te-ci on pull requests. The third user mentioned in the PR description (pstjohn) was already present in the allowlist at line 55 and was correctly not duplicated.

  • Adds cspades and jomitchellnv to the github.actor allowlist in .github/workflows/trigger-ci.yml
  • No duplicate entries introduced; no logic or security issues found
  • Change is consistent with the existing pattern used throughout the allowlist

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, low-risk allowlist addition with no logic changes.
  • The change only appends two || github.actor == '...' conditions to an existing allowlist. No duplicate entries are introduced (the previously flagged pstjohn duplicate has already been resolved), and the change follows the exact same pattern as every other entry in the list. There are no control flow, security, or runtime concerns.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/trigger-ci.yml Adds two new GitHub users (cspades, jomitchellnv) to the CI trigger allowlist. Change is correct and consistent with existing patterns; no duplicates or logic issues introduced.

Sequence Diagram

sequenceDiagram
    participant User as GitHub User
    participant GH as GitHub Actions
    participant Auth as Authorization Job
    participant VS as Vulnerability-scan Job
    participant JT as Job-trigger Job

    User->>GH: Comment starting with `/te-ci`
    GH->>Auth: Trigger on issue_comment (created)
    Auth->>Auth: Check github.actor in allowlist<br/>(now includes cspades, jomitchellnv)
    alt Actor is authorized
        Auth->>Auth: Run blossom-ci (AUTH)
        Auth->>VS: Pass args output
        VS->>VS: Checkout code & run blossom-action
        VS->>JT: Trigger after Vulnerability-scan
        JT->>JT: Run blossom-ci (START-CI-JOB)
    else Actor is NOT authorized
        Auth-->>GH: Condition fails, workflow skipped
    end
Loading

Last reviewed commit: ba8cedb

Comment thread .github/workflows/trigger-ci.yml Outdated
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx merged commit a5d7464 into NVIDIA:main Mar 12, 2026
9 of 12 checks passed
vthumbe1503 pushed a commit to ksivaman/TransformerEngine-1 that referenced this pull request Apr 1, 2026
* Added new people to CI

Signed-off-by: Przemek Tredak <ptredak@nvidia.com>

* Removing duplicate

Signed-off-by: Przemek Tredak <ptredak@nvidia.com>

---------

Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants