Skip to content

Fix convergence table rendering in README.rst - #3109

Merged
ksivaman merged 1 commit into
NVIDIA:mainfrom
ksivaman:fix_readme_rendering
Jun 9, 2026
Merged

Fix convergence table rendering in README.rst#3109
ksivaman merged 1 commit into
NVIDIA:mainfrom
ksivaman:fix_readme_rendering

Conversation

@ksivaman

@ksivaman ksivaman commented Jun 9, 2026

Copy link
Copy Markdown
Member

Description

Fix convergence table rendering in README. Blocking wheel uploads to PyPI.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Fix convergence table rendering in README

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: ksivamani <ksivamani@nvidia.com>
@ksivaman
ksivaman requested a review from timmoon10 June 9, 2026 18:04
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes extra trailing whitespace from the MPT-1.3B URL cell in the convergence table in README.rst, which was causing RST rendering to fail and blocking wheel uploads to PyPI.

  • The MPT-1.3B source URL cell had trailing spaces that pushed the cell content beyond the column boundary defined by the grid-table separator lines, breaking RST table rendering.
  • No logic, functionality, or other documentation is affected.

Confidence Score: 5/5

Safe to merge — a one-character whitespace trim to a documentation table cell with no functional impact.

The change removes a small number of trailing spaces from a single RST grid-table cell. No logic, APIs, or build scripts are touched; the only effect is correcting the table column alignment so the RST renderer accepts it.

No files require special attention.

Important Files Changed

Filename Overview
README.rst Trailing whitespace removed from the MPT-1.3B URL cell to bring it within the RST grid-table column boundary and fix rendering.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[README.rst RST table cell\nMPT-1.3B URL with trailing spaces] -->|Exceeds column boundary| B[RST renderer fails]
    B --> C[PyPI wheel upload blocked]
    D[Remove extra trailing spaces\nURL cell fits within column width] -->|Fixed| E[RST renders correctly]
    E --> F[PyPI wheel upload unblocked]
Loading

Reviews (1): Last reviewed commit: "Fix convergence table render" | Re-trigger Greptile

@timmoon10 timmoon10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ksivaman
ksivaman merged commit 4bf946d into NVIDIA:main Jun 9, 2026
10 of 13 checks passed
@ksivaman
ksivaman deleted the fix_readme_rendering branch June 9, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants