[Pytorch] [NCCL EP] Allow zero tokens for an EP rank in eager mode - #3276
Merged
Conversation
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Collaborator
Author
|
/te-ci L1 |
for more information, see https://pre-commit.ci
Contributor
Greptile SummaryUpdates expert-parallel eager execution to accept empty tensors with null data pointers.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Router
participant Dispatch as EP Dispatch
participant Rank as Zero-receive EP Rank
participant Combine as EP Combine
Router->>Dispatch: Route all tokens to another rank
Dispatch->>Rank: "Empty tensors (numel = 0, data = null)"
Rank->>Combine: Empty expert output
Combine-->>Router: Reconstructed local-token result
Router->>Rank: Backward gradients
Rank-->>Router: Completed backward pass
Reviews (7): Last reviewed commit: "Merge branch 'main' into allow_ep_rank_n..." | Re-trigger Greptile |
phu0ngng
approved these changes
Jul 29, 2026
phu0ngng
requested changes
Aug 3, 2026
phu0ngng
left a comment
Collaborator
There was a problem hiding this comment.
Hold this PR until the NCCL-EP fix is upstreamed and submodule dependency is bumped.
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Collaborator
Author
|
/te-ci L1 |
phu0ngng
approved these changes
Aug 4, 2026
Collaborator
|
Pipeline 61101023 passed except L1_pytorch_distributed_unittest--B200_8GPU is out of time due to deprecated messages, which is unrelated to this PR. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For eager mode, there could be case where certain EP ranks do not receive any token, based on the routing strategy. This PR relax the constraint to allow such behavior.
Fixes # (issue)
Type of change
Checklist: