Fix hybrid fp8 test guard - #3492
Merged
Merged
Conversation
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Collaborator
Author
|
/te-ci pytorch |
Contributor
Greptile SummaryThis PR prevents two hybrid FSDP2 tests from failing on systems without FP8 support by adding matching pytest skip guards.
Confidence Score: 5/5The PR appears safe to merge; both guards align with the runtime requirements of their respective tests. No actionable defects were identified, and both tests would otherwise reach code paths that reject environments where the shared FP8 availability check fails. Important Files Changed
Reviews (1): Last reviewed commit: "Fix hybrid fp8 test guard" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: