feat(catalog): register STORAGE as a capability platform

[abegnoche]

Problem

The 0.9.0 catalog push surfaced the new storage tests in the catalog UI, but the storage capability itself never appeared (https://stg.ai-cloud-labs.nvidia.com/catalog).

Root cause: the storage suite (suites/storage.yaml, introduced in #439) was never registered in PLATFORM_CONFIGS in isvtest/catalog.py, and the storage label has no LABEL_TO_PLATFORM mapping. Pushed catalogs therefore omit STORAGE from the platform axis and storage tests carry an empty platforms list — the UI derives capabilities from exactly those two fields. The backend (V17 catalog axis metadata) and frontend (axis read from the uploaded document, unknown names title-cased) already support new capabilities; this was the missing client-side piece. Unlike security (#370) and observability (#431), which registered their platform in the same PR that created the suite, the storage suite grew across many PRs and the registration step was never hit.

Changes

• isvtest/catalog.py: register "STORAGE": ["suites/storage.yaml"] in PLATFORM_CONFIGS and "storage": "STORAGE" in LABEL_TO_PLATFORM. 19 tests (Hss*/Directory* + shared checks) now carry the STORAGE platform, and the document axis includes it.
• isvreporter/platform.py: add the STORAGE constant and storage alias. The storage suite declares tests.platform: storage, which normalize_platform() silently coerced to the KUBERNETES default when reporting test runs.
• scripts/validate_suite_wiring.py (+ validate-suites pre-commit hook): every suites/*.yaml must now be registered in PLATFORM_CONFIGS, so the next capability suite cannot ship unregistered. The hook also triggers on isvtest/catalog.py and the script itself. Enforced hook-only by design: make test stays green when untracked scratch suites are present in the working tree.
• Tests updated accordingly (platform axis assertion, isvreporter storage normalization, unit test for the new hook check).

Verification

• make test (all three packages + scripts), make lint, uvx pre-commit run -a all pass.
• isvctl catalog list --json: axis now [..., SLURM, STORAGE, VM], 19 entries with STORAGE platform.
• Negative check: an unregistered scratch suite in suites/ makes the validate-suites hook fail with a pointed message while make test still passes.

Rollout note

isvctl catalog push skips upload when the isvTestVersion already exists, so re-pushing 0.9.0 will not pick this up — this needs to land in a 0.9.1 release followed by a catalog push (or the stored 0.9.0 catalog row must be deleted server-side before a re-push).

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added STORAGE as a supported platform, included across platform normalization, configuration/schema docs, and the test catalog platform axis.
  • Canonicalizes storage (case-insensitive) to STORAGE.
• Bug Fixes
  • Strengthened suite validation to flag unregistered suite YAMLs and prevent unknown platforms from being silently coerced.
• Tests
  • Added coverage for STORAGE behavior and for suite registration/registry round-trip consistency checks.
• Chores
  • Broadened suite/validation matching in a pre-commit hook and expanded wiring validation checks.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9835aa3d-507c-4a28-afb2-ef9eb5f8f3bd

📥 Commits

Reviewing files that changed from the base of the PR and between e30d669 and 2a458ce.

📒 Files selected for processing (1)

• scripts/validate_suite_wiring.py

💤 Files with no reviewable changes (1)

• scripts/validate_suite_wiring.py

---

📝 Walkthrough

Walkthrough

The change adds STORAGE as a supported platform, centralizes catalog platform registration, and validates suite registration and platform normalization consistency.

Changes

STORAGE platform support

Layer / File(s)	Summary
Platform contract and configuration isvreporter/src/isvreporter/platform.py, isvctl/src/isvctl/config/schema.py, isvreporter/tests/test_platform.py	Adds the canonical STORAGE platform, alias normalization, configuration documentation, and tests for normalization, validity, and config parsing.
Catalog platform registration isvtest/src/isvtest/catalog_platforms.py, isvtest/src/isvtest/catalog.py, isvtest/tests/test_catalog.py	Introduces the centralized platform registry, re-exports it from the catalog module, and includes STORAGE in the expected platform axis.
Suite registration validation scripts/validate_suite_wiring.py, scripts/tests/test_validate_suite_wiring.py, .pre-commit-config.yaml	Derives suite labels from the registry, checks suite registration and platform round-tripping, adds guardrail tests, and expands pre-commit hook coverage.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SuiteFiles
  participant ValidateSuiteWiring
  participant CatalogPlatformRegistry
  participant PlatformNormalizer
  SuiteFiles->>ValidateSuiteWiring: provide suite YAML files
  ValidateSuiteWiring->>CatalogPlatformRegistry: read PLATFORM_CONFIGS
  CatalogPlatformRegistry-->>ValidateSuiteWiring: return registered suite paths
  ValidateSuiteWiring->>PlatformNormalizer: normalize registered platforms
  PlatformNormalizer-->>ValidateSuiteWiring: return canonical platforms
  ValidateSuiteWiring-->>SuiteFiles: report registration or consistency errors

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: registering STORAGE as a new catalog capability platform.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🔐 TruffleHog Secret Scan

✅ No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

_{🕐 Last updated: 2026-07-16 15:13:22 UTC | Commit: 5d5d8b6}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@isvctl/src/isvctl/config/schema.py`:
- Around line 361-364: Wrap the description value in the platform Field
declaration into adjacent string literals so no source line exceeds 120
characters, while preserving the exact metadata text and formatting the existing
Field definition consistently.

In `@scripts/validate_suite_wiring.py`:
- Line 214: Update the --check argument help text in main() to mention platform
registration failures alongside missing test_id and labels, reflecting the
errors returned by wiring_errors() and platform_registration_errors().

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5592b6e1-cb31-4f9a-ba6d-e8db01cb925f

📥 Commits

Reviewing files that changed from the base of the PR and between 25ad740 and 5d5d8b6.

📒 Files selected for processing (8)

• .pre-commit-config.yaml
• isvctl/src/isvctl/config/schema.py
• isvreporter/src/isvreporter/platform.py
• isvreporter/tests/test_platform.py
• isvtest/src/isvtest/catalog.py
• isvtest/tests/test_catalog.py
• scripts/tests/test_validate_suite_wiring.py
• scripts/validate_suite_wiring.py