Skip to content

chore(deps): bump version of nvkind to 24c190e#1260

Merged
mchmarny merged 2 commits into
NVIDIA:mainfrom
cdesiniotis:bump-nvkind-24c190e
Jun 9, 2026
Merged

chore(deps): bump version of nvkind to 24c190e#1260
mchmarny merged 2 commits into
NVIDIA:mainfrom
cdesiniotis:bump-nvkind-24c190e

Conversation

@cdesiniotis

Copy link
Copy Markdown
Contributor

Summary

This PR bumps the version of nvkind to pull in the changes from NVIDIA/nvkind#76 and reverts the hack added in #1258 that patched a Go file in nvkind.

Motivation / Context

Fixes: #1259

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
…IA#1237) (NVIDIA#1258)"

This reverts commit eddc075.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@cdesiniotis cdesiniotis requested a review from a team as a code owner June 9, 2026 19:04

@ArangoGutierrez ArangoGutierrez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Welcome to AICR, @cdesiniotis! Thanks for your first pull request.

Before review, please ensure:

  • All commits are signed off per the DCO
  • CI checks pass (tests, lint, security scan)
  • The PR description explains the why behind your changes

A maintainer will review this soon.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 9d72ce57-bfab-4537-9cdb-cd4b04e6b50b

📥 Commits

Reviewing files that changed from the base of the PR and between eddc075 and 91d3497.

📒 Files selected for processing (2)
  • .github/actions/gpu-cluster-setup/install-nvkind.sh
  • .settings.yaml

📝 Walkthrough

Walkthrough

This PR simplifies nvkind binary installation by removing local source cloning, verification, and sed-patching logic. The installation script now validates that NVKIND_VERSION is set and installs nvkind directly via go install. This simplification is enabled by updating the .settings.yaml nvkind dependency pin to a commit that includes the upstream fix for the --config-source=command--config-source=file flag change, eliminating the need for a local patch.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • NVIDIA/aicr#1258: Original PR that introduced the clone-patch-build workaround for nvkind; this PR reverts that workaround now that the upstream fix is available.

Suggested labels

area/ci

Suggested reviewers

  • dims
  • lockwobr
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: bumping nvkind to commit 24c190e, which is the primary focus of this pull request.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation for bumping nvkind and referencing the linked issue and upstream change.
Linked Issues check ✅ Passed The PR fully addresses issue #1259 by: (1) bumping .settings.yaml nvkind to commit 24c190e which includes upstream nvkind#76, and (2) reverting install-nvkind.sh to plain go install without the local patch.
Out of Scope Changes check ✅ Passed All changes are directly in scope: the nvkind version bump and the reversion of the install script patch as required by issue #1259. No extraneous modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mchmarny mchmarny merged commit d4342ae into NVIDIA:main Jun 9, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert install-nvkind.sh to plain go install once nvkind/PR#76 lands

4 participants