Update nvidia-ctk --config-source flag from 'command' to 'file'#76
Merged
cdesiniotis merged 1 commit intoJun 9, 2026
Merged
Conversation
Using command as a config source can be problematic with containerd. The 'containerd config dump' command does not reliably inform us of the config file version currently set in the top-level /etc/containerd/config.toml file. For newer versions of containerd that support config versions 3 (or even 4), we fail to generate a valid drop-in config file if the top-level config is using version 2 of the containerd config schema. In kind worker nodes (e.g. kindest/node:$k8s-ver), the top-level /etc/containerd/config.toml is populated with enough information for nvidia-ctk to create a functional drop-in file at /etc/containerd/conf.d/99-nvidia.toml. So it should be safe, at least in kind environments, to use 'file' as our config source. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
tariq1890
approved these changes
Jun 9, 2026
dims
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using command as a config source can be problematic with containerd. The 'containerd config dump' command does not reliably inform us of the config file version currently set in the top-level /etc/containerd/config.toml file. For newer versions of containerd that support config versions 3 (or even 4), we fail to generate a valid drop-in config file if the top-level config is using version 2 of the containerd config schema.
In kind worker nodes (e.g. kindest/node:$k8s-ver), the top-level /etc/containerd/config.toml is populated with enough information for nvidia-ctk to create a functional drop-in file at /etc/containerd/conf.d/99-nvidia.toml. So it should be safe, at least in kind environments, to use 'file' as our config source.