Remove NCCL>=2.10.3 check#2000
Merged
Merged
Conversation
as 2.10.3 was released in 2021 April. ref: https://docs.nvidia.com/deeplearning/nccl/archives/nccl_2303/release-notes/rel_2-10-3.html Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the NCCL version gating logic for building the nccl_p2p_cuda contrib extension when --nccl_p2p is enabled, making the extension build unconditional (subject to CUDA being available).
Changes:
- Removed the build-time NCCL version probe (
_nccl_version_getter) for--nccl_p2p. - Removed the conditional “skip + warning” path and always registers the
nccl_p2p_cudaCUDAExtension.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
867
to
+872
| # NOTE: Requires NCCL >= 2.10.3 | ||
| if has_flag("--nccl_p2p", "APEX_NCCL_P2P"): | ||
| if "--nccl_p2p" in sys.argv: | ||
| sys.argv.remove("--nccl_p2p") | ||
| raise_if_cuda_home_none("--nccl_p2p") | ||
| # Check NCCL version. | ||
| _nccl_version_getter = load( | ||
| name="_nccl_version_getter", | ||
| sources=[ | ||
| "apex/contrib/csrc/nccl_p2p/nccl_version.cpp", | ||
| "apex/contrib/csrc/nccl_p2p/nccl_version_check.cu", | ||
| ], | ||
| ) | ||
| _available_nccl_version = _nccl_version_getter.get_nccl_version() | ||
| if _available_nccl_version >= (2, 10): | ||
| ext_modules.append( | ||
| CUDAExtension( | ||
| name="nccl_p2p_cuda", | ||
| sources=[ | ||
| "apex/contrib/csrc/nccl_p2p/nccl_p2p_cuda.cu", | ||
| "apex/contrib/csrc/nccl_p2p/nccl_p2p.cpp", | ||
| ], | ||
| extra_compile_args={"cxx": ["-O3"] + generator_flag}, | ||
| ) | ||
| ) | ||
| else: | ||
| warnings.warn( | ||
| f"Skip `--nccl_p2p` as it requires NCCL 2.10.3 or later, but {_available_nccl_version[0]}.{_available_nccl_version[1]}" | ||
| ext_modules.append( |
Aidyn-A
approved these changes
May 11, 2026
Collaborator
Aidyn-A
left a comment
Aidyn-A
left a comment
There was a problem hiding this comment.
Agree, we are now on NCCL v2.30.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as 2.10.3 was released in 2021 April.
ref: https://docs.nvidia.com/deeplearning/nccl/archives/nccl_2303/release-notes/rel_2-10-3.html