Skip to content

Remove NCCL>=2.10.3 check #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crcrpar merged 1 commit into from
May 13, 2026
Merged

Remove NCCL>=2.10.3 check #2000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,30 +869,16 @@ def check_cudnn_version_and_warn(global_option: str, required_cudnn_version: int
if "--nccl_p2p" in sys.argv:
sys.argv.remove("--nccl_p2p")
raise_if_cuda_home_none("--nccl_p2p")
# Check NCCL version.
_nccl_version_getter = load(
name="_nccl_version_getter",
sources=[
"apex/contrib/csrc/nccl_p2p/nccl_version.cpp",
"apex/contrib/csrc/nccl_p2p/nccl_version_check.cu",
],
)
_available_nccl_version = _nccl_version_getter.get_nccl_version()
if _available_nccl_version >= (2, 10):
ext_modules.append(
CUDAExtension(
name="nccl_p2p_cuda",
sources=[
"apex/contrib/csrc/nccl_p2p/nccl_p2p_cuda.cu",
"apex/contrib/csrc/nccl_p2p/nccl_p2p.cpp",
],
extra_compile_args={"cxx": ["-O3"] + generator_flag},
)
)
else:
warnings.warn(
f"Skip `--nccl_p2p` as it requires NCCL 2.10.3 or later, but {_available_nccl_version[0]}.{_available_nccl_version[1]}"
ext_modules.append(
CUDAExtension(
name="nccl_p2p_cuda",
sources=[
"apex/contrib/csrc/nccl_p2p/nccl_p2p_cuda.cu",
"apex/contrib/csrc/nccl_p2p/nccl_p2p.cpp",
],
extra_compile_args={"cxx": ["-O3"] + generator_flag},
)
)

# note (mkozuki): Now `--fast_bottleneck` option (i.e. apex/contrib/bottleneck) depends on `--peer_memory` and `--nccl_p2p`.
if has_flag("--fast_bottleneck", "APEX_FAST_BOTTLENECK"):
Expand Down