Skip to content

Conversation

@farhadrgh
Copy link
Collaborator

Description

NVIDIA-NeMo/NeMo#14365

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by applying the relevant labels:

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Authorizing CI Runs

We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.

  • If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will
    automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
  • If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an
    /ok to test comment on the pull request to trigger CI. This will need to be done for each new commit.

Usage

TODO: Add code snippet

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

Signed-off-by: Farhad Ramezanghorbani <farhadr@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 31, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jstjohn
Copy link
Collaborator

jstjohn commented Jul 31, 2025

/ok to test 36edea9

@jstjohn
Copy link
Collaborator

jstjohn commented Jul 31, 2025

I expect tests to fail due to increases in memory on nemo top of tree mentioned here: #1013

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.34%. Comparing base (962d141) to head (b4f3dd6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         148      148           
  Lines        9766     9766           
=======================================
  Hits         8139     8139           
  Misses       1627     1627           

Signed-off-by: Farhad Ramezanghorbani <farhadr@nvidia.com>
@farhadrgh
Copy link
Collaborator Author

/ok to test b4f3dd6

@farhadrgh farhadrgh enabled auto-merge July 31, 2025 22:06
@farhadrgh farhadrgh added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 58edf11 Aug 1, 2025
16 checks passed
@farhadrgh farhadrgh deleted the farhadr/bump_nemo branch August 1, 2025 01:31
@farhadrgh farhadrgh restored the farhadr/bump_nemo branch November 3, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants