Amoradzadeh/fix implicit filter cp bug by moradza · Pull Request #1524 · NVIDIA/bionemo-framework

moradza · 2026-03-16T16:21:53Z

Description

Fixes bug in subquadratic-ops path in implicit filter implementation.
Removes duplicate codes.

Usage

TODO: Add code snippet

Type of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactor
Documentation update
Other (please describe):

CI Pipeline Configuration

Configure CI behavior by applying the relevant labels. By default, only basic unit tests are run.

ciflow:skip - Skip all CI tests for this PR
ciflow:notebooks - Run Jupyter notebooks execution tests for bionemo2
ciflow:slow - Run slow single GPU integration tests marked as @pytest.mark.slow for bionemo2
ciflow:all - Run all tests (unit tests, slow tests, and notebooks) for bionemo2. This label can be used to enforce running tests for all bionemo2.
ciflow:all-recipes - Run tests for all recipes (under bionemo-recipes). This label can be used to enforce running tests for all recipes.

Unit tests marked as @pytest.mark.multi_gpu or @pytest.mark.distributed are not run in the PR pipeline.

For more details, see CONTRIBUTING

Note

By default, only basic unit tests are run. Add appropriate labels to enable an additional test coverage.

Authorizing CI Runs

We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.

If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an
/ok to test comment on the pull request to trigger CI. This will need to be done for each new commit.

Triggering Code Rabbit AI Review

To trigger a code review from code rabbit, comment on a pull request with one of these commands:

@coderabbitai review - Triggers a standard review
@coderabbitai full review - Triggers a comprehensive review

See https://docs.coderabbit.ai/reference/review-commands for a full list of commands.

Pre-submit Checklist

I have tested these changes locally
I have updated the documentation accordingly
I have added/updated tests as needed
All existing tests pass successfully

Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>

copy-pr-bot · 2026-03-16T16:21:58Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

coderabbitai · 2026-03-16T16:22:03Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3e53f458-bfe1-4fb5-a05e-02bf62c82a02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch amoradzadeh/fix_implicit_filter_cp_bug

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jstjohn

Thank you! Once you've tested feel free to merge.

jstjohn · 2026-03-30T15:38:07Z

/ok to test

copy-pr-bot · 2026-03-30T15:38:10Z

/ok to test

@jstjohn, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

jstjohn · 2026-03-30T15:38:57Z

/ok to test

copy-pr-bot · 2026-03-30T15:39:01Z

/ok to test

@jstjohn, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

jstjohn · 2026-03-30T15:39:57Z

/ok to test 1f81db9

jstjohn · 2026-03-30T15:55:30Z

Pulled into #1536

@moradza

### Description * Adds in and verifies the evo2 20b checkpoint. * Pulls in bugfix for CP from @moradza's #1524 #### Usage See example notebooks. Output from the BRCA notebook with the 20b checkpoint: <img width="783" height="499" alt="image" src="https://github.com/user-attachments/assets/2c9f3bc0-8b15-48be-8a99-e9184c43df5a" /> ### Type of changes  - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [x] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels. By default, only basic unit tests are run. - [ciflow:skip](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:skip) - Skip all CI tests for this PR - [ciflow:notebooks](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:notebooks) - Run Jupyter notebooks execution tests - [ciflow:slow](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:slow) - Run slow single GPU integration tests marked as @pytest.mark.slow - [ciflow:all](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:all) - Run all tests (unit tests, slow tests, and notebooks). This label can be used to enforce running all framework tests. - [ciflow:all-recipes](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:all-recipes) - Run tests for all recipes (under bionemo-recipes). This label can be used to enforce running tests for all recipes. Unit tests marked as `@pytest.mark.multi_gpu` or `@pytest.mark.distributed` are not run in the PR pipeline. For more details, see [CONTRIBUTING](CONTRIBUTING.md) > [!NOTE] > By default, only basic unit tests are run. Add appropriate labels to enable an additional test coverage. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. - If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) - If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. #### Triggering Code Rabbit AI Review To trigger a code review from code rabbit, comment on a pull request with one of these commands: - @coderabbitai review - Triggers a standard review - @coderabbitai full review - Triggers a comprehensive review See https://docs.coderabbit.ai/reference/review-commands for a full list of commands. ### Pre-submit Checklist  - [x] I have tested these changes locally - [x] I have updated the documentation accordingly - [ ] I have added/updated tests as needed - [ ] All existing tests pass successfully --------- Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com> Signed-off-by: John St. John <jstjohn@nvidia.com> Signed-off-by: John St John <jstjohn@nvidia.com> Co-authored-by: amoradzadeh <amoradzadeh@nvidia.com>

moradza added 3 commits March 16, 2026 09:10

fix the subq_ops path

976a900

Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>

remove duplicate code

897387d

Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>

enable test_predict.py

fd09a43

Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>

moradza requested review from cspades, dorotat-nv, jomitchellnv, jstjohn, jwilber, pstjohn, savitha-eng and trvachov as code owners March 16, 2026 16:21

jstjohn approved these changes Mar 16, 2026

View reviewed changes

moradza enabled auto-merge March 17, 2026 00:02

Merge branch 'main' into amoradzadeh/fix_implicit_filter_cp_bug

1f81db9

jstjohn closed this Mar 30, 2026

auto-merge was automatically disabled March 30, 2026 15:55
Pull request was closed

jstjohn mentioned this pull request Mar 30, 2026

Evo2 20b support and validation #1536

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amoradzadeh/fix implicit filter cp bug#1524

Amoradzadeh/fix implicit filter cp bug#1524
moradza wants to merge 4 commits intomainfrom
amoradzadeh/fix_implicit_filter_cp_bug

moradza commented Mar 16, 2026

Uh oh!

copy-pr-bot Bot commented Mar 16, 2026

Uh oh!

coderabbitai Bot commented Mar 16, 2026 •

edited

Loading

Review skipped

Uh oh!

jstjohn left a comment

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

copy-pr-bot Bot commented Mar 30, 2026

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

copy-pr-bot Bot commented Mar 30, 2026

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

moradza commented Mar 16, 2026

Description

Usage

Type of changes

CI Pipeline Configuration

Authorizing CI Runs

Triggering Code Rabbit AI Review

Pre-submit Checklist

Uh oh!

copy-pr-bot Bot commented Mar 16, 2026

Uh oh!

coderabbitai Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

jstjohn left a comment

Choose a reason for hiding this comment

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

copy-pr-bot Bot commented Mar 30, 2026

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

copy-pr-bot Bot commented Mar 30, 2026

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

jstjohn commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Mar 16, 2026 •

edited

Loading