Refactored load & download_bionemo_data into bionemo-core#396
Merged
malcolmgreaves merged 1 commit intomainfrom Nov 7, 2024
Merged
Refactored load & download_bionemo_data into bionemo-core#396malcolmgreaves merged 1 commit intomainfrom
load & download_bionemo_data into bionemo-core#396malcolmgreaves merged 1 commit intomainfrom
Conversation
malcolmgreaves
requested review from
DejunL,
dorotat-nv,
farhadrgh,
guoqing-zhou,
jstjohn,
pstjohn and
skothenhill-nv
as code owners
Contributor
Author
|
/build-ci |
malcolmgreaves
force-pushed
the
mg/refactor_load_into_core
branch
from
a59885e to
cc4aa90
Compare
Contributor
Author
|
/build-ci |
jstjohn
approved these changes
Nov 4, 2024
malcolmgreaves
force-pushed
the
mg/refactor_load_into_core
branch
from
cc4aa90 to
ea10664
Compare
pstjohn
reviewed
Nov 4, 2024
Collaborator
|
/build-ci |
malcolmgreaves
force-pushed
the
mg/refactor_load_into_core
branch
from
ea10664 to
1bc8a1b
Compare
malcolmgreaves
force-pushed
the
mg/refactor_load_into_core
branch
2 times, most recently
from
453e160 to
5bfbced
Compare
Contributor
Author
|
/build-ci |
malcolmgreaves
force-pushed
the
mg/refactor_load_into_core
branch
from
5bfbced to
44714da
Compare
`bionemo-testing` re-exports the same values defined in `__all__`: they are imported from `bionemo-core` as the implementations have moved. Note that the tests have also moved. Now, all sub-packages can use `load` at runtime, not just during tests. All previous imports of `bionemo.testing.load` have been changed to `bionemo.core.load`. Additionally moves over the YAML resource files from bionemo-testing into bionemo-core & adjusted the `get_all_resources` function. This PR also fixes an error in the naming convention for `bionemo-core`'s tests.
malcolmgreaves
force-pushed
the
mg/refactor_load_into_core
branch
from
44714da to
627bc26
Compare
malcolmgreaves
added a commit
that referenced
this pull request
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bionemo-testingre-exports the same values defined in__all__: theyare imported from
bionemo-coreas the implementations have moved.Note that the tests have also moved.
Now, all sub-packages can use
loadat runtime, not just during tests.All previous imports of
bionemo.testing.loadhave been changed tobionemo.core.load.Additionally moves over the YAML resource files from bionemo-testing
into bionemo-core & adjusted the
get_all_resourcesfunction.This PR also fixes an error in the naming convention for
bionemo-core's tests.