Prepare reduce-by-key tuning policy for lookahead#10078
Merged
Conversation
10 tasks
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (7)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe reduce-by-key tuning policy now uses an algorithm tag with nested lookback parameters. Dispatch paths, adapters, benchmarks, and tests construct and consume the updated policy structure. Reduce-by-key policy migration
Suggested reviewers: Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 242aac14-2ba0-482c-aef3-77ed66ef6f08
📒 Files selected for processing (7)
cub/benchmarks/bench/reduce/by_key.cucub/cub/device/device_run_length_encode.cuhcub/cub/device/dispatch/dispatch_reduce_by_key.cuhcub/cub/device/dispatch/dispatch_streaming_reduce_by_key.cuhcub/cub/device/dispatch/tuning/tuning_reduce_by_key.cuhcub/test/catch2_test_device_reduce_by_key_env_api.cucub/test/catch2_test_device_reduce_env.cu
This comment has been minimized.
This comment has been minimized.
NaderAlAwar
approved these changes
Jul 22, 2026
NaderAlAwar
left a comment
NaderAlAwar
left a comment
Contributor
There was a problem hiding this comment.
LGTM, coderabbit nodiscard comment worth addressing
oleksandr-pavlyk
approved these changes
Jul 22, 2026
Fixes part of: NVIDIA#10075 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bernhardmgruber
force-pushed
the
tune_reduce_by_key
branch
from
July 22, 2026 15:14
762ecde to
3008a6d
Compare
bernhardmgruber
enabled auto-merge (squash)
July 22, 2026 16:08
This comment has been minimized.
This comment has been minimized.
3 tasks
Contributor
🥳 CI Workflow Results🟩 Finished in 18h 44m: Pass: 100%/287 | Total: 13d 17h | Max: 2h 47m | Hits: 17%/1234808See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of: #10075