[backport 3.5.x] Remove __constant_wrapper from 3.5 release - #10588
Open
davebayer wants to merge 1 commit into
Open
[backport 3.5.x] Remove __constant_wrapper from 3.5 release#10588davebayer wants to merge 1 commit into
__constant_wrapper from 3.5 release#10588davebayer wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (23)
💤 Files with no reviewable changes (23)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request removes the constant wrapper header, its public utility include, related version metadata, and the associated constant wrapper tests. ChangesConstant wrapper removal
Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
miscco
approved these changes
Aug 3, 2026
Contributor
⏱️ CCCL compile-time benchmark comparison: Public headers compile-time benchResult: 2 regression row(s), 3 improvement row(s) above threshold.
Artifacts: reports and traces Direct file processing
🔴 Direct file processing — Regressions
🟢 Direct file processing — Improvements
|
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 23m: Pass: 100%/115 | Total: 5d 17h | Max: 4h 22m | Hits: 42%/1802361See results here. |
Contributor
Author
|
pre-commit.ci autofix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are problems with
__constant_wrapper, our weekly testing shows that gcc-10 even fails to parse the source code. I'd rather completely remove it from 3.5 release, since it's not even used anywhere.