libcu++: atomic backend naming unification. - #10922
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (13)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe PR renames generated CUDA atomic helpers, internal order and operand entities, local atomic helpers, and device dispatch calls from legacy CUDA prefixes to the CUDA atomic naming alignment
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR performs a localized atomic backend naming update with no actionable merge-blocking risk remaining beyond normal checks and review. Comment |
🥳 CI Workflow Results🟩 Finished in 2h 24m: Pass: 100%/117 | Total: 3d 03h | Max: 1h 30m | Hits: 59%/646965See results here. |
| out << R"XXX( | ||
| template <class _Fn, class _Sco> | ||
| static inline _CCCL_DEVICE bool __cuda_atomic_compare_swap_memory_order_dispatch(_Fn& __cuda_cas, int __success_memorder, int __failure_memorder, _Sco) { | ||
| static inline _CCCL_DEVICE bool __cuda_atomic_compare_exchange_order_dispatch(_Fn& __cuda_cas, int __success_memorder, int __failure_memorder, _Sco) { |
There was a problem hiding this comment.
I'm not a fan of using __cuda prefix, I'd much rather see something like __cccl_atomic
There was a problem hiding this comment.
My logic here is that this means "this is a part of the cuda::atomic implementation". But additionally, __cuda_atomic just codifies an existing naming scheme that existed at the top layer of the backend; if we move to __cccl, this will be a larger rename.
There was a problem hiding this comment.
I am a bit torn here.
We usually want to prefix with __cccl rather anything else to make sure where something belongs.
However, this is the implementation of cuda::atomic so this makes it appropriate in this context
Description
This is a mechanical extraction of the renaming aspects of #10908 into its own PR.
Checklist