Merge release-v171 into main

[podkidyshev]

Summary

Upstream release v1.7.1 changes into main

Test Plan

• Automated CI

Additional Notes

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Slurm job lifecycle

Layer / File(s)	Summary
Runner tracking and shutdown cleanup src/cloudai/systems/slurm/single_sbatch_runner.py	SingleSbatchRunner.run() tracks submitted jobs, kills jobs detected during shutdown, and always removes jobs from tracking.
Shutdown and completion coverage tests/test_single_sbatch_runner.py	Tests cover shutdown during monitoring or submission, plus completed jobs that should not be killed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jeffnvidia

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately states that release-v171 is being merged into main.
Description check	✅ Passed	The description is clearly related to the merge and release v1.7.1 changes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch release-v171

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/cloudai/systems/slurm/single_sbatch_runner.py`:
- Around line 190-193: Update the job submission flow around _submit_test so
placeholder jobs returned in dry-run mode are neither appended to tracking nor
passed to SlurmSystem.kill(); gate both operations on self.mode == "run". Add a
regression test covering shutdown during dry-run and verify no cancellation is
issued for the placeholder job.
- Around line 192-203: Move the self.shutting_down check and
self.system.kill(job) call inside the try/finally scope in the job monitoring
flow, preserving the existing loop behavior. Ensure self.jobs.remove(job) always
executes, including when killing the job raises.

In `@tests/test_single_sbatch_runner.py`:
- Around line 534-555: Extend the shutdown regression coverage around
test_run_tracks_and_cancels_job_on_shutdown with a cancellation-failure case
where SlurmSystem.kill raises, asserting runner.jobs is still cleared, and a
dry-run case asserting shutdown does not invoke Slurm cancellation. Reuse the
existing runner/job setup and monitoring shutdown flow, varying only the mode
and kill behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: d3a4d7e5-0f13-432d-8a55-7ac8810ba561

📥 Commits

Reviewing files that changed from the base of the PR and between 09f728c and f597e38.

📒 Files selected for processing (2)

• src/cloudai/systems/slurm/single_sbatch_runner.py
• tests/test_single_sbatch_runner.py